Piotr Ożarowski wrote:
> [Yann Le Boulanger, 2009-01-04]
>> Package URL: http://www.lagaule.org/debian/python-libasyncns
> 
> http://www.lagaule.org/debian/python-libasyncns/libasyncns-python_0.7-1.dsc
> 
> package looks really good
> 
> few comments:
> * in debian/copyright: add a link to /usr/share/common-licenses/LGPL
> * s/Author(s)/Author
> * s/Debian packaging is (C)/Debian packaging is ©

all done

> * 0.7.1 is out (yeah, you requested for a check a month ago, sorry)

Yes, I'll use latest version when libasyncns will be packaged (I'll have
to do it as maintainer doesn't seem to answer)

> * pkg-config is missing in build depends

Done

> * ping us once libasyncns >=0.4 will be available in Debian
>   (yeah, I saw 510269) - I didn't build it yet (so I couldn't test it)
> * if 'import libasyncns' is not how you import the module, you have to
>   change the binary package name

I indeed do "import libasyncns"

> * consider building docs (ship it in -doc package if they're big)

Any example package where I could look for the way to do that?

> * short description is too long (lintian will warn you about it)

I rediced it.

Thanks for the review, I'll come back when libasync will be packaged.
-- 
Yann

-- 
Yann


-- 
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to