On Mon, 22 Sep 2008, Cyril Brulebois wrote: Hi!
> Mauro Lizaur <[EMAIL PROTECTED]> (22/09/2008): > > [0] http://lusers.com.ar/packages/python-osd_0.2.14-4.dsc > > Hmm, many remarks: > - debian/rules modifications aren't documented at all in the changelog. Added a line explaining why i use $(CURDIR) instead of $PWD. > - the libxosd2 dependency should be pulled by ${shlibs:Depends}, you > should never have to include a dependency manually like that. Removed the hardcoded libxosd2 and left ${shlibs:Depends} instead. > - you didn't document that you dropped Conflicts and Replaces, nor why. Added as well. > - you didn't document that you added a debian/watch file. Idem > - your not mentioning the case change (s/python/Python/) in the first > line of the long description is OK, though. > I though this change being rather /small/, didn't need to be added to the changelog. But you're right I should add a desc about this too, so I'm including this change too. > So you've got to fix some bits before someone can sponsor this. > Well, i reuploaded this to the URL i left on my previous reply. Regards, Mauro -- JID: [EMAIL PROTECTED] | [EMAIL PROTECTED] http://lusers.com.ar/ | http://gcoop.com.ar 2B82 A38D 1BA5 847A A74D 6C34 6AB7 9ED6 C8FD F9C1
signature.asc
Description: Digital signature
