On Sat, 2004-04-24 at 04:41, Olaf Hering wrote:
> On Sat, Apr 24, Christoph Hellwig wrote:
> > On Sat, Apr 24, 2004 at 05:02:51PM +1000, Benjamin Herrenschmidt wrote:
> > > Hi Sven !
> > >
> > > The current CDs won't boot a G5 with the -power4 option. The problem
> > > is that the kernel contains legacy drivers (8250 serial, etc...) that
> > > are fine for IBM POWER4 hardware, but will lockup a G5. You really need
> > > different kernel images for now.
> >
> > Sure seems to have lots of little patches to check the ppc subarch in
> > all those drivers. Any plan to get them into mainline while we're at
> > it.
>
> I disabled all these drivers with a
> if(_machine == _MACH_Pmac)
> return -ENODEV;
...
> they really should go into mainline.
Yuck. How about something that doesn't look so PowerPC-specific?
You're contaminating non-arch drivers with arch-specific code.
if(has_isa_bus)
return -ENODEV;
Better yet, find a way to flag the driver init functions
so that they don't even execute until an ISA bus is found.
