On Fri, Mar 05, 2004 at 08:05:05PM +1100, Benjamin Herrenschmidt wrote: > On Fri, 2004-03-05 at 19:58, Russell King wrote: > > On Fri, Mar 05, 2004 at 06:54:31PM +1100, Benjamin Herrenschmidt wrote: > > > Ok, so I finally got a hand on the problems. A mix of bugs in > > > the driver, bugs in the HW, and bugs in the TTY layer ! pfiew. > > > > I'm not even going to bother reviewing these changes - the gratuitous > > change of "up" to "uap" makes this task virtually impossible. > > Oh... and the change wasn't gratuitous... "up" do actually conflict > with up() as soon as you try to use a semaphore :)
Yes, I know - but the point is its impossible to review, and I think you at least have an extra level of locking which isn't needed. But I wouldn't know because of the huge number of changes which make it impossible to read. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core
