On Wed, 2004-01-07 at 20:53, Sven Luther wrote: > On Wed, Jan 07, 2004 at 07:30:06PM +1100, Benjamin Herrenschmidt wrote: > > > > > 1) could a #ifdef __powerpc__ not be enough ? > > > > No. _machine is only defined for the "multiarch" config (PREP/CHRP/PMAC) > > Ok. I suppose it doesn't make sense also to include the #ifdef > CONFIG_ALL_PPC in a #ifdef __powerpc__ ?
Yup, useless to stack them. > > > 2) The other failures in rtc_init return -EIO, not -ENODEV. > > > > Well, in this case, -ENODEV makes more sense, though nothing really > > cares except the kind of error message the user will get when using > > it as a module. > > I think i will keep it as the others for the debian package. Why ? The error is definitely not an IO error :) Nothing really relies on this error code anyway... Ben.
