Hi Ben,
On Mon, Mar 14, 2005 at 01:33:42PM +1100, Benjamin Herrenschmidt wrote:
> + /* Look for voltage GPIO */
> volt_gpio_np = of_find_node_by_name(NULL, "cpu-vcore-select");
> + reg = (u32 *)get_property(volt_gpio_np, "reg", NULL);
> + voltage_gpio = *reg;
> if (!volt_gpio_np){
> printk(KERN_ERR "cpufreq: missing cpu-vcore-select gpio\n");
> return 1;
> }
>
> - reg = (u32 *)get_property(volt_gpio_np, "reg", NULL);
> - voltage_gpio = *reg;
Is this part of the change really safe?
Can we call get_property with NULL as the first argument?All the best, Jochen -- http://seehuhn.de/
signature.asc
Description: Digital signature
