Your message dated Mon, 21 Aug 2017 16:07:13 +0200 with message-id <20170821140712.w5kerbk7fsn4t...@alf.mars> and subject line Re: Bug#872808: [debian-policy] nocheck DEB_BUILD_OPTIONS DEB_BUILD_PROFILES has caused the Debian Bug report #872808, regarding [debian-policy] nocheck DEB_BUILD_OPTIONS DEB_BUILD_PROFILES to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 872808: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872808 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: debian-policy Version: 4.0.1.0 Severity: normal I think the following patch is needed even if profiles are not fully specified. Maybe an example about nodoc and help2man will also help. The nocheck should check both BUILD_OPTIONS and BUILD_PROFILES. It will help when implementing as policy profiles diff --git a/policy/ch-source.rst b/policy/ch-source.rst index f706a13..d3d868c 100644 --- a/policy/ch-source.rst +++ b/policy/ch-source.rst @@ -465,7 +465,8 @@ The meaning of the following tags has been standardized: ``nocheck`` This tag says to not run any build-time test suite provided by the - package. + package. This tag could be also specified using + ``DEB_BUILD_PROFILES`` variable with nocheck flag ``nodoc`` This tag says to skip any build steps that only generate package @@ -531,7 +532,7 @@ order to make it work for your package. build: # ... - ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) + ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS $DEB_BUILD_PROFILES))) # Code to run the package test suite. endif
signature.asc
Description: This is a digitally signed message part.
--- End Message ---
--- Begin Message ---On Mon, Aug 21, 2017 at 03:37:35PM +0200, Bastien ROUCARIÈS wrote: > index f706a13..d3d868c 100644 > --- a/policy/ch-source.rst > +++ b/policy/ch-source.rst > @@ -465,7 +465,8 @@ The meaning of the following tags has been standardized: > > ``nocheck`` > This tag says to not run any build-time test suite provided by the > - package. > + package. This tag could be also specified using > + ``DEB_BUILD_PROFILES`` variable with nocheck flag > > ``nodoc`` > This tag says to skip any build steps that only generate package The build profile spec[1] says that you must add nocheck to DEB_BUILD_OPTIONS when adding the nocheck profile. > @@ -531,7 +532,7 @@ order to make it work for your package. > > build: > # ... > - ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) > + ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS $DEB_BUILD_PROFILES))) > # Code to run the package test suite. > endif > This is unnecessary by the above comment. Helmut [1] https://wiki.debian.org/BuildProfileSpec#Registered_profile_names
--- End Message ---
