Adrian Bunk: > On Wed, Aug 16, 2017 at 11:37:00AM +0000, Ximin Luo wrote: >> [..] >> >> Fair enough. I actually spotted that but thought it was better to get >> "something" into Policy rather than nitpick. I guess other people were >> thinking similar things. Well, lesson learnt, I will be more forceful next >> time. >> ... > > What is the point of getting "something" into policy, when it is known > to not match existing practice and that what is being added to policy > will be ignored by everyone? > >> The sentence I amended said "most environment variables" so our intent is >> clear. >> ... > > This is not about "intent", this is about giving an exact definition > of reproducibility for Debian. > > The definition should then match what is recorded in .buildinfo > and what the reproducible builds infrastructure is testing. >
The exact wording that was added, was a too-loose requirement. I'm now proposing to make the requirement more strict, in accordance with the tests that we're running. Do you have any comments on my proposal? - a set of environment variable values; and + a set of reserved environment variable values; and then later: + A "reserved" environment variable is defined as DEB_*, DPKG_, SOURCE_DATE_EPOCH, BUILD_PATH_PREFIX_MAP, variables listed by dpkg-buildflags and other variables explicitly used by buildsystems to affect build output, excluding any variables used by non-build programs to affect their behaviour. Explicitly, this excludes TERM, HOME, LOGNAME, USER, PATH and likely any variables ending with *PATH. X -- GPG: ed25519/56034877E1F87C35 GPG: rsa4096/1318EFAC5FBBDBCE https://github.com/infinity0/pubkeys.git