On Sun, Jul 04, 2010 at 08:29:32AM -0700, Russ Allbery wrote: > Steve Langasek <vor...@debian.org> writes:
> > This force-reload also caught my eye when I first read the patch, but I > > think this should be treated as a separate bug. logrotate scripts are *not* > > maintainer scripts, and recommending use of invoke-rc.d for non-maintainer > > scripts is a separate substantive change that ought to be discussed in its > > own bug. > Using it definitely isn't a bug, though, so is it okay if I change this > example while we're in here anyway? (I selfishly would like to just > because I'd already written the patch that way. :)) I'm not nearly so certain that it's not a bug to use invoke-rc.d here. The desired semantics of a logrotate script are "after rotating the log, *iff the daemon is running*, reload it to trigger it to reopen the logfile; otherwise do nothing". *Neither* the existing example, nor invoke-rc.d, gives these semantics; and switching to invoke-rc.d only makes the wrongness of logrotate's behavior less difficult to understand. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slanga...@ubuntu.com vor...@debian.org -- To UNSUBSCRIBE, email to debian-policy-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100704192042.gb19...@dario.dodds.net
