Your message dated Sun, 16 Oct 2022 21:20:55 +0000
with message-id <e1okb43-00dvnu...@fasolo.debian.org>
and subject line Bug#1021841: fixed in setbfree 0.8.11-3
has caused the Debian Bug report #1021841,
regarding setbfree FTCBFS -- multiple reasons
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1021841: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021841
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: setbfree
Version: 0.8.11-2
Severity: normal
Tags: patch
X-Debbugs-Cc: debian-cr...@lists.debian.org
Hi,
setbfree Fails to cross build because:
- It hard-codes pkg-config everywhere and that defaults to the build
architecture
while cross-building. This can be resolved by using PKG_CONFIG and setting it
to this value only if it is previously un-set.
And PKG_CONFIG can be set to the pkg-config prefixed with the
architecure-triplet
while cross building.
- It uses strip extensively. While for debian systems, simply removing the strip
call from all makefiles could be OK, since dh_strip will simply take care of it.
But, it'd be hard to make things upstream-able
if desired at some point. So I sent STRIP to the <arch-triplet-prefix>-strip for
cross builds.
A patch can be found attached with this mail.
Thanks!
-- System Information:
Debian Release: bookworm/sid
APT prefers testing
APT policy: (990, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 5.18.0-3-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
>From 131fbc61c9baf052d0693b7f7d63d69fcd970d14 Mon Sep 17 00:00:00 2001
From: Nilesh Patra <nil...@debian.org>
Date: Sat, 15 Oct 2022 22:19:54 +0530
Subject: [PATCH] Get package cross-building
---
debian/patches/cross.patch | 252 +++++++++++++++++++++++++++++++++++++
debian/patches/series | 1 +
debian/rules | 9 +-
3 files changed, 261 insertions(+), 1 deletion(-)
create mode 100644 debian/patches/cross.patch
diff --git a/debian/patches/cross.patch b/debian/patches/cross.patch
new file mode 100644
index 0000000..1dd9be8
--- /dev/null
+++ b/debian/patches/cross.patch
@@ -0,0 +1,252 @@
+--- a/b_chorato/Makefile
++++ b/b_chorato/Makefile
+@@ -3,7 +3,7 @@
+
+ LOADLIBES = -lm
+ override CFLAGS+= -I../src
+-override CFLAGS+=`pkg-config --cflags lv2` -fvisibility=hidden
++override CFLAGS+=`$(PKG_CONFIG) --cflags lv2` -fvisibility=hidden
+
+ targets=
+
+--- a/b_overdrive/Makefile
++++ b/b_overdrive/Makefile
+@@ -12,16 +12,16 @@
+ targets+=lv2
+ endif
+
+-ifeq ($(shell pkg-config --exists liblo && echo yes), yes)
+- override CFLAGS+=-DHAVE_LIBLO `pkg-config --cflags liblo`
+- LOADLIBES+=`pkg-config --libs liblo`
++ifeq ($(shell $(PKG_CONFIG) --exists liblo && echo yes), yes)
++ override CFLAGS+=-DHAVE_LIBLO `$(PKG_CONFIG) --cflags liblo`
++ LOADLIBES+=`$(PKG_CONFIG) --libs liblo`
+ endif
+
+-ifeq ($(shell pkg-config --exists jack && echo yes)$(OVERDRIVEJACK), yesyes)
++ifeq ($(shell $(PKG_CONFIG) --exists jack && echo yes)$(OVERDRIVEJACK),
yesyes)
+ targets+=jboverdrive
+ binaries+=jboverdrive
+- override CFLAGS+=-DHAVE_JACK `pkg-config --cflags jack`
+- LOADLIBES+=`pkg-config --libs jack`
++ override CFLAGS+=-DHAVE_JACK `$(PKG_CONFIG) --cflags jack`
++ LOADLIBES+=`$(PKG_CONFIG) --libs jack`
+ endif
+
+ OVMSRC=\
+--- a/b_reverb/Makefile
++++ b/b_reverb/Makefile
+@@ -3,7 +3,7 @@
+ include ../git2lv2.mk
+
+ LOADLIBES = -lm
+-override CFLAGS+=`pkg-config --cflags lv2` -fvisibility=hidden
++override CFLAGS+=`$(PKG_CONFIG) --cflags lv2` -fvisibility=hidden
+
+ targets=reverb.o
+
+--- a/b_synth/Makefile
++++ b/b_synth/Makefile
+@@ -4,7 +4,7 @@
+
+ LOADLIBES = -lm
+ override CFLAGS+= -I../src -I../b_overdrive -I../b_reverb -I../b_whirl
+-override CFLAGS+=`pkg-config --cflags lv2` -DLV2SYNTH -fvisibility=hidden
++override CFLAGS+=`$(PKG_CONFIG) --cflags lv2` -DLV2SYNTH -fvisibility=hidden
+ targets=
+
+ LV2NAME=b_synth
+--- a/b_whirl/Makefile
++++ b/b_whirl/Makefile
+@@ -7,7 +7,7 @@
+ endif
+
+ LOADLIBES = -lm
+-override CFLAGS+=`pkg-config --cflags lv2` -fvisibility=hidden
++override CFLAGS+=`$(PKG_CONFIG) --cflags lv2` -fvisibility=hidden
+
+ targets=whirl.o eqcomp.o
+
+@@ -25,7 +25,7 @@
+ $(warning This plugin GUI needs https://github.com/x42/robtk)
+ $(info set the RW environment variale to the location of the robtk
headers)
+ else
+- HAVE_RTK = $(shell pkg-config --exists pango cairo $(PKG_GL_LIBS) &&
echo yes)
++ HAVE_RTK = $(shell $(PKG_CONFIG) --exists pango cairo $(PKG_GL_LIBS) &&
echo yes)
+ endif
+
+ ifeq ($(HAVE_RTK), yes)
+@@ -79,7 +79,7 @@
+ -shared $(LV2LDFLAGS) $(LDFLAGS)
+
+ JACKCFLAGS=$(CFLAGS) $(GLUICFLAGS) $(LIC_CFLAGS) -Wno-unused-function
+-JACKCFLAGS+=`pkg-config --cflags jack lv2 pango pangocairo $(PKG_GL_LIBS)`
++JACKCFLAGS+=`$(PKG_CONFIG) --cflags jack lv2 pango pangocairo $(PKG_GL_LIBS)`
+ JACKLIBS=-lm $(GLUILIBS) $(LIC_LOADLIBES)
+
+ $(eval x42_whirl_JACKSRC = lv2.c whirl.c)
+--- a/common.mak
++++ b/common.mak
+@@ -29,17 +29,18 @@
+ override CFLAGS += -DVERSION="\"$(VERSION)\""
+
+ STRIP ?= strip
++PKG_CONFIG ?= pkg-config
+
+ CXXFLAGS ?= $(OPTIMIZATIONS) -Wall
+ GLUICFLAGS=-I. -I.. -Wno-unused-function
+ STRIPFLAGS=-s
+
+ # check for LV2
+-LV2AVAIL=$(shell pkg-config --exists lv2 && echo yes)
++LV2AVAIL=$(shell $(PKG_CONFIG) --exists lv2 && echo yes)
+
+ LV2UIREQ=
+ # check for LV2 idle thread
+-ifeq ($(shell pkg-config --atleast-version=1.6.0 lv2 || echo no), no)
++ifeq ($(shell $(PKG_CONFIG) --atleast-version=1.6.0 lv2 || echo no), no)
+ override CFLAGS+=-DOLD_SUIL
+ else
+ GLUICFLAGS+=-DHAVE_IDLE_IFACE
+@@ -48,7 +49,7 @@
+ endif
+
+ # check for lv2_atom_forge_object new in 1.8.1 deprecates
lv2_atom_forge_blank
+-ifeq ($(shell pkg-config --atleast-version=1.8.1 lv2 && echo yes), yes)
++ifeq ($(shell $(PKG_CONFIG) --atleast-version=1.8.1 lv2 && echo yes), yes)
+ override CFLAGS += -DHAVE_LV2_1_8
+ endif
+
+@@ -92,8 +93,8 @@
+ EXTENDED_RE=-r
+ endif
+
+-GLUICFLAGS+=`pkg-config --cflags cairo pango $(PKG_GL_LIBS)`
+-GLUILIBS+=`pkg-config $(PKG_UI_FLAGS) --libs cairo pango pangocairo
$(PKG_GL_LIBS)`
++GLUICFLAGS+=`$(PKG_CONFIG) --cflags cairo pango $(PKG_GL_LIBS)`
++GLUILIBS+=`$(PKG_CONFIG) $(PKG_UI_FLAGS) --libs cairo pango pangocairo
$(PKG_GL_LIBS)`
+
+ ifneq ($(XWIN),)
+ GLUILIBS+=-lpthread -lusp10
+@@ -129,7 +130,7 @@
+ endif
+
+ ifeq ($(MOD),)
+- HAVE_UI=$(shell pkg-config --exists $(PKG_GL_LIBS) ftgl && echo
$(FONT_FOUND))
++ HAVE_UI=$(shell $(PKG_CONFIG) --exists $(PKG_GL_LIBS) ftgl && echo
$(FONT_FOUND))
+ else
+ HAVE_UI=no
+ endif
+@@ -148,31 +149,31 @@
+ ifeq ($(IS_OSX), yes)
+ UIDEPS+=../pugl/pugl_osx.m
+ UILIBS=../pugl/pugl_osx.m -framework Cocoa -framework OpenGL
+- UILIBS+=`pkg-config --variable=libdir ftgl`/libftgl.a `pkg-config
--variable=libdir ftgl`/libfreetype.a
+- UILIBS+=`pkg-config --libs zlib`
++ UILIBS+=`$(PKG_CONFIG) --variable=libdir ftgl`/libftgl.a `$(PKG_CONFIG)
--variable=libdir ftgl`/libfreetype.a
++ UILIBS+=`$(PKG_CONFIG) --libs zlib`
+ UILIBS+=-lm $(OSXCOMPAT)
+ else
+ ifeq ($(IS_WIN), yes)
+ UIDEPS+=../pugl/pugl_win.cpp
+ UILIBS=../pugl/pugl_win.cpp
+- UILIBS+=`pkg-config --variable=libdir ftgl`/libftgl.a `pkg-config
--variable=libdir ftgl`/libfreetype.a
+- UILIBS+=`pkg-config --libs zlib`
++ UILIBS+=`$(PKG_CONFIG) --variable=libdir ftgl`/libftgl.a `$(PKG_CONFIG)
--variable=libdir ftgl`/libfreetype.a
++ UILIBS+=`$(PKG_CONFIG) --libs zlib`
+ UILIBS+=-lws2_32 -lwinmm -lopengl32 -lglu32 -lgdi32 -lcomdlg32 -lpthread
+ else
+ UIDEPS+=../pugl/pugl_x11.c
+- override CFLAGS+=`pkg-config --cflags gl glu`
++ override CFLAGS+=`$(PKG_CONFIG) --cflags gl glu`
+ UILIBS=../pugl/pugl_x11.c -lX11
+ ifeq ($(STATICBUILD), yes)
+- UILIBS+=`pkg-config --libs gl glu`
+- UILIBS+=`pkg-config --variable=libdir ftgl`/libftgl.a `pkg-config
--variable=libdir ftgl`/libfreetype.a
+- UILIBS+=`pkg-config --libs zlib`
++ UILIBS+=`$(PKG_CONFIG) --libs gl glu`
++ UILIBS+=`$(PKG_CONFIG) --variable=libdir ftgl`/libftgl.a
`$(PKG_CONFIG) --variable=libdir ftgl`/libfreetype.a
++ UILIBS+=`$(PKG_CONFIG) --libs zlib`
+ else
+- UILIBS+=`pkg-config --libs gl glu ftgl`
++ UILIBS+=`$(PKG_CONFIG) --libs gl glu ftgl`
+ endif
+ UICFLAGS+=-DFONTFILE=\"$(FONTFILE)\"
+ endif
+ endif
+- UICFLAGS+=`pkg-config --cflags freetype2` `pkg-config --cflags ftgl`
-DHAVE_FTGL -DUINQHACK=Sbf
++ UICFLAGS+=`$(PKG_CONFIG) --cflags freetype2` `$(PKG_CONFIG) --cflags ftgl`
-DHAVE_FTGL -DUINQHACK=Sbf
+ endif
+
+ #NOTE: midi.c and cfgParser.c needs to be re-compiled w/o HAVE_ASEQ
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -44,31 +44,31 @@
+ ../b_overdrive/overdrive.h
+
+
+-ifeq ($(shell pkg-config --exists jack || echo no), no)
++ifeq ($(shell $(PKG_CONFIG) --exists jack || echo no), no)
+ $(error "JACK is required - install libjack-dev or libjack-jackd2-dev")
+ endif
+
+-ifeq ($(shell pkg-config --exists alsa && echo yes)$(ENABLE_ALSA), yesyes)
+- override CFLAGS+=-DHAVE_ASEQ `pkg-config --cflags alsa`
+- LOADLIBES+=`pkg-config --libs alsa`
++ifeq ($(shell $(PKG_CONFIG) --exists alsa && echo yes)$(ENABLE_ALSA), yesyes)
++ override CFLAGS+=-DHAVE_ASEQ `$(PKG_CONFIG) --cflags alsa`
++ LOADLIBES+=`$(PKG_CONFIG) --libs alsa`
+ endif
+
+
+-override CFLAGS+=`pkg-config --cflags jack`
++override CFLAGS+=`$(PKG_CONFIG) --cflags jack`
+
+ ifeq ($(USEWEAKJACK),1)
+ override CFLAGS+=-DUSE_WEAK_JACK -I$(RW)
+ LOADLIBES+=-ldl
+ WEAKJACK=$(RW)weakjack/weak_libjack.c
+ else
+- LOADLIBES+=`pkg-config --libs jack`
++ LOADLIBES+=`$(PKG_CONFIG) --libs jack`
+ endif
+
+-ifeq ($(shell pkg-config --exists sndfile \
++ifeq ($(shell $(PKG_CONFIG) --exists sndfile \
+ && test -f /usr/include/zita-convolver.h -o -f
/usr/local/include/zita-convolver.h \
+ && echo yes), $(ENABLE_CONVOLUTION))
+- override CFLAGS+= -DHAVE_ZITACONVOLVE `pkg-config --cflags sndfile`
+- LOADLIBES+=-lzita-convolver `pkg-config --libs sndfile`
++ override CFLAGS+= -DHAVE_ZITACONVOLVE `$(PKG_CONFIG) --cflags sndfile`
++ LOADLIBES+=-lzita-convolver `$(PKG_CONFIG) --libs sndfile`
+ OBJS+=../b_conv/convolution.o
+ HEADERS+=../b_conv/convolution.h
+ BXCC=$(CXX)
+--- a/ui/Makefile
++++ b/ui/Makefile
+@@ -3,7 +3,7 @@
+ WINDRES=$(XWIN)-windres
+
+ override CFLAGS+= -I../src -I../b_overdrive -I../b_reverb -I../b_whirl
-I../b_synth/
+-override CFLAGS+=`pkg-config --cflags lv2` -DLV2SYNTH -DREQUIRE_UI
++override CFLAGS+=`$(PKG_CONFIG) --cflags lv2` -DLV2SYNTH -DREQUIRE_UI
+
+ JACKEXTRA=
+ OSXJACKWRAP=
+@@ -32,12 +32,12 @@
+ UICFLAGS+=-DUSE_WEAK_JACK
+ JACKEXTRA+=$(RW)weakjack/weak_libjack.c
+ else
+- UILIBS+=`pkg-config --libs jack`
++ UILIBS+=`$(PKG_CONFIG) --libs jack`
+ endif
+
+-ifeq ($(shell pkg-config --exists liblo && echo yes), yes)
+- UICFLAGS+=`pkg-config $(PKG_UI_FLAGS) --cflags liblo` -DHAVE_LIBLO
+- UILIBS+=`pkg-config $(PKG_UI_FLAGS) --libs liblo`
++ifeq ($(shell $(PKG_CONFIG) --exists liblo && echo yes), yes)
++ UICFLAGS+=`$(PKG_CONFIG) $(PKG_UI_FLAGS) --cflags liblo` -DHAVE_LIBLO
++ UILIBS+=`$(PKG_CONFIG) $(PKG_UI_FLAGS) --libs liblo`
+ endif
+
+ targets=
diff --git a/debian/patches/series b/debian/patches/series
index ad747cc..0d6b421 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
Use_DejaVu_font.patch
FTBFS.patch
Fix_spelling_error.patch
+cross.patch
diff --git a/debian/rules b/debian/rules
index ca71cf0..33ddb22 100755
--- a/debian/rules
+++ b/debian/rules
@@ -2,6 +2,12 @@
export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow
+ifeq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE))
+STRIP := strip
+else
+STRIP := $(DEB_HOST_GNU_TYPE)-strip
+export PKG_CONFIG = $(DEB_HOST_GNU_TYPE)-pkg-config
+endif
%:
dh $@
@@ -9,7 +15,8 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow
override_dh_auto_build:
dh_auto_build -- \
PREFIX=/usr \
- OPTIMIZATIONS=-O3
+ OPTIMIZATIONS=-O3 \
+ STRIP=$(STRIP)
override_dh_auto_install:
dh_auto_install -- \
--
2.35.1
--- End Message ---
--- Begin Message ---
Source: setbfree
Source-Version: 0.8.11-3
Done: Dennis Braun <d_br...@kabelmail.de>
We believe that the bug you reported is fixed in the latest version of
setbfree, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1021...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dennis Braun <d_br...@kabelmail.de> (supplier of updated setbfree package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 16 Oct 2022 22:55:34 +0200
Source: setbfree
Architecture: source
Version: 0.8.11-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <d_br...@kabelmail.de>
Closes: 1021841
Changes:
setbfree (0.8.11-3) unstable; urgency=medium
.
* Fix cross building. Thanks Nilesh! (Closes: #1021841)
Checksums-Sha1:
097a159c3c68615c9a33818fcca68d7a9384aa53 2299 setbfree_0.8.11-3.dsc
7accdc8e998a0335fc5a96cd890fb8cc79d10d16 14580 setbfree_0.8.11-3.debian.tar.xz
8b4eb83956a85e5df1b67b5d1dbcd9677766a11b 6746
setbfree_0.8.11-3_source.buildinfo
Checksums-Sha256:
e6aa7ec688c101a51de6bf746e063e266fb3d033607004001a6b2ec83dde045e 2299
setbfree_0.8.11-3.dsc
0a66da5303e3432931e9a5a513eccbeb0832e63b4701d2276e0972846765a276 14580
setbfree_0.8.11-3.debian.tar.xz
4b17611eb490a9ad63702f79bf0199a39b7b689af3431664522edc2aa7443828 6746
setbfree_0.8.11-3_source.buildinfo
Files:
772927f5a0724fdae5899664ffa45b85 2299 sound optional setbfree_0.8.11-3.dsc
de6b8f57bd686169abfaf812fa71b895 14580 sound optional
setbfree_0.8.11-3.debian.tar.xz
c000564c081fc5c749563ee1f8c72859 6746 sound optional
setbfree_0.8.11-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJJBAEBCgAzFiEEPLfDAq+1fmGoxhfdY06lXZArmDYFAmNMcFcVHGRfYnJhdW5A
a2FiZWxtYWlsLmRlAAoJEGNOpV2QK5g2YD4QAJksr5SuKgVJG3eJaNll8ZBLl1nx
c7UUh/arV43mTpziJNGyoEAyKsD2WVUB2eW0C3Ki1boyOm+mMBNxm1hyHgxi5Ljn
/mmtGjX/Q2F/HcZ+jKmrsuYy8J9lH01I3G137ZZylXu+D1pCQYFlQM1X6Fralg5B
tEHAfTxOI0fcBGUgzsyCSQBQ5BZoHtp0uMjHw7FlfWwL9Vt5vSf5HhUo3wynh1tC
B0ZM2JxMzCwyN0rXON72f/N8pgZf/eceGvXTpsLOB5HVy208uPVDZs/Ctrbup+x0
1GSMuJyR+M2md658TQHXvjJ0g0FEkT8tV/E8Gr2Jd6LEz/q5Y78fSRDyuFsB5jJ1
TJgwiwfMpAi3K9vcexgndzXaSoJVQSI//yPW9v8XNQf7kUCcBmEG1sJU22q0ppKJ
0pTV/4XpF2B/E0YTEjNV84sJWee3sHEFtpWZd9wYudKqUXnuafg8HByHe09qtGTC
GhDW907C2sqCMLftS8x5JqXdRb5hgsNlHqjqAVUxB0iimaFTz1SGuvGtoE211lp/
l2Zuey7DvR9FeRJEwEBxDRQaJdKDe5//9jBshjHV0iPl5T6IowGkD8acxAs3oLfI
pD5G7SGjOt+kgWZWosMc8rOrf+eocXa4XFeDVKY26QBdVhgskZtVNt5PWFMLNZhd
u17y0kk8dfRpanlL
=Fo/p
-----END PGP SIGNATURE-----
--- End Message ---
