control: tag -1 moreinfo control: owner -1 ! On Fri, Feb 05, 2016 at 03:04:19PM +0100, Giulio Paci wrote: > I am looking for a sponsor for my package "msi-keyboard":
alright. > https://anonscm.debian.org/cgit/collab-maint/msi-keyboard.git cool! finally somebody coming here with a git repository! though: * I see no tags, I expect to see at least the upstream/* tags (also otherwise gbp can be noisy and annoying) * the HEAD points to master; given that the packaging branch is "debian", please configure the remote repository on collab-maint to have HEAD point to "debian" instead, so that cloning the repository gives you the packaging branch even without specifying it. * as said you are using a non-standard repository layout, so I expect debian/gbp.conf to be explicitly configured to use 'debian-branch = debian' and 'upstream-branch = master' * also, Vcs-Git does not specify the branch (which is kinda optional if you set correctly HEAD on the remote repository, but it wouldn't harm to write it here too) * I'm looking partly shocked at the commit 6fc1eec66c259cefeeb13453c3ceeb206fb24a55 why did you *substituted* the pristine-tar data? You should always just add them. that's just about the git repository. review on the package itself: * debian/control: + please sort the build-deps with wrap-and-sort or with cme or + please bump Standards-Version to 3.9.7 + please drop the build-dep on dpkg-dev, that version is old enough and dpkg-dev is in build-essential + please build-dep on debhelper (>= 9), no need for that ~ + please drop the version constriction on qt5-qmake, that version is old enough * debian/changelog: + I see there is a weird space between the month and the year, how so? * debian/copyright: + there is a \t at line 9, please just use spaces for consistency. I have a feeling you editor is configured to show a tab as 8 spaces, but this is not everybody's configuration, in fact here the line is indeed in a weird way. + please use the license names as specified by DEP-5, so name it "BSD-3-clause" and not lowercase * debian/msi-keyboard.{post,pre}inst: + what aree these? Quasi-empty files? * debian/patches: + debian/patches/series is empty, please remove the whole directory Then, here it fails to build: debian/rules override_dh_auto_build make[1]: Entering directory '/build/msi-keyboard-1.0' PATH="`pwd`":"$PATH" help2man msi-keyboard --no-info --name="MSI steelseries keyboard color changer" > debian/msi-keyboard.1 help2man: can't get `--help' info from msi-keyboard Try `--no-discard-stderr' if option outputs to stderr debian/rules:12: recipe for target 'override_dh_auto_build' failed make[1]: *** [override_dh_auto_build] Error 2 make[1]: Leaving directory '/build/msi-keyboard-1.0' debian/rules:6: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 E: Failed autobuilding of package I wonder why not just use `help2man ./msi-keyboard ...` instead of messing around with PATH (which is probably what went wrong here). -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
