On Thu, Jan 14, 2016 at 02:31:25PM +0100, Pilisi Gergely wrote: > please check the new version. I fixed a couple of things, but the remaining > ones got me...
sorry, took some time. My routine started again after the winter/christmas break.. :) A thing. you changed the .orig.tar.gz. Don't do that. Once a release has been made you can't really change it. Those are the diffs between the old one and this: https://paste.debian.net/366300/ Technically speaking, since that file has not yet been uploaded to ftp-master it can still be changed, but what about other users of it? > 2016-01-13 15:22 GMT+01:00 Mattia Rizzolo <mat...@debian.org>: > > hardening-wrapper can just go away, the package builds fine anyway. > > The canonical way to have hardening buildflags is to export > > DEB_BUILD_MAINT_OPTIONS=hardening=+all in d/rules (instead of > > DEB_BUILD_HARDENING). > > Having a look at Makefile.cfg I see: > > * CFLAGS ain't used (instead there is a CCFLAGS variable); > > * CXXFLAGS ignores the external env. > > You may need to patch it a bit. > > hardening-wrapper wiped out, but new lintian warning showed up: > hardening-no-relro. > Tried to DEB_BUILD_MAINT_OPTIONS=hardening=+all, warning still there. > Tried to set CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS) and use it > in the Makefile, same result. In debian/rules, the line about the hardening was commented out. That means something. Anyway, adding debian-specific code to upstream is not that nice, other distributions would have troubles for nothing. CFLAGS & friends are in the env, so there is no real need to call dpkg-buildflags that way. Just do something like -CPPFLAGS := $(shell dpkg-buildflags --get CPPFLAGS) +CPPFLAGS := $(CPPFLAGS) or directly CPPFLAGS += -DYY_NO_INPUT In the diff in the tarball I see some changes from CCFLAGS to CFLAGS. whatever, dpkg-buildflags exports/uses CFLAGS and not CCFLAGS, but you can avoid changing upstream sources by just adding export CCFLAGS = $(shell dplg-buildflags --get CFLAGS) in d/rules, but YMMV, your call here. but most importantly, I couldn't get eclipse-titan build today. First it failed with /usr/bin/ld: LoggerPlugin_dynamic.o: undefined reference to symbol 'dlclose@@GLIBC_2.2.5' //lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status Makefile:307: recipe for target 'libttcn3-dynamic.so' failed Then, I added -ldl to LDFLAGS and retried, just to have Parallel_main.o: In function `main': /build/eclipse-titan-5.4.1/core/Parallel_main.cc:203: undefined reference to `TCov::close_file()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:208: undefined reference to `TTCN_Runtime::install_signal_handlers()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:209: undefined reference to `TTCN_Snapshot::initialize()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:210: undefined reference to `TTCN_Logger::initialize_logger()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:211: undefined reference to `TTCN_Logger::set_executable_name(char const*)' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:212: undefined reference to `TTCN_Logger::set_start_time()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:218: undefined reference to `Module_List::pre_init_modules()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:219: undefined reference to `TTCN_Runtime::hc_main(char const*, char const*, unsigned short)' Parallel_main.o: In function `TTCN_Runtime::is_hc()': /build/eclipse-titan-5.4.1/core/Runtime.hh:92: undefined reference to `TTCN_Runtime::executor_state' Parallel_main.o: In function `main': /build/eclipse-titan-5.4.1/core/Parallel_main.cc:246: undefined reference to `TTCN_Runtime::restore_signal_handlers()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:247: undefined reference to `TTCN_Logger::close_file()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:248: undefined reference to `TCov::close_file()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:251: undefined reference to `TTCN_Logger::clear_parameters()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:252: undefined reference to `PORT::clear_parameters()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:253: undefined reference to `COMPONENT::clear_component_names()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:254: undefined reference to `TTCN_EncDec::clear_error()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:256: undefined reference to `TTCN_Logger::terminate_logger()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:257: undefined reference to `TTCN_Snapshot::terminate()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:223: undefined reference to `COMPONENT::clear_component_names()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:226: undefined reference to `TTCN_Logger::close_file()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:227: undefined reference to `TCov::close_file()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:229: undefined reference to `TTCN_Logger::set_start_time()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:233: undefined reference to `TTCN_Runtime::ptc_main()' Parallel_main.o: In function `process_options': /build/eclipse-titan-5.4.1/core/Parallel_main.cc:136: undefined reference to `TTCN_Runtime::install_signal_handlers()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:137: undefined reference to `TTCN_Logger::initialize_logger()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:138: undefined reference to `Module_List::pre_init_modules()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:139: undefined reference to `Module_List::list_testcases()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:143: undefined reference to `TTCN_Logger::terminate_logger()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:157: undefined reference to `Module_List::print_version()' Parallel_main.o: In function `main': /build/eclipse-titan-5.4.1/core/Parallel_main.cc:231: undefined reference to `TTCN_Runtime::mtc_main()' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:235: undefined reference to `TTCN_error(char const*, ...)' /build/eclipse-titan-5.4.1/core/Parallel_main.cc:242: undefined reference to `TTCN_Logger::log_str(TTCN_Logger::Severity, char const*)' Parallel_main.o: In function `__static_initialization_and_destruction_0': /build/eclipse-titan-5.4.1/core/../common/version.h:94: undefined reference to `reffer::reffer(char const*)' Parallel_main.o: In function `JSON_Tokenizer::JSON_Tokenizer(bool)': /build/eclipse-titan-5.4.1/core/../common/JSON_Tokenizer.hh:115: undefined reference to `JSON_Tokenizer::init(char const*, unsigned long)' Parallel_main.o: In function `__static_initialization_and_destruction_0': /build/eclipse-titan-5.4.1/core/../common/JSON_Tokenizer.hh:164: undefined reference to `JSON_Tokenizer::~JSON_Tokenizer()' collect2: error: ld returned 1 exit status Makefile:292: recipe for target 'parallel-dynamic' failed make[2]: *** [parallel-dynamic] Error 1 make[2]: *** Waiting for unfinished jobs.... Single_main.o: In function `signal_handler(int)': /build/eclipse-titan-5.4.1/core/Single_main.cc:58: undefined reference to `TTCN_Logger::close_file()' Single_main.o: In function `main': /build/eclipse-titan-5.4.1/core/Single_main.cc:94: undefined reference to `Module_List::single_control_part()' /build/eclipse-titan-5.4.1/core/Single_main.cc:176: undefined reference to `self' /build/eclipse-titan-5.4.1/core/Single_main.cc:176: undefined reference to `COMPONENT::operator=(int)' Single_main.o: In function `TTCN_Runtime::set_state(TTCN_Runtime::executor_state_enum)': /build/eclipse-titan-5.4.1/core/Runtime.hh:86: undefined reference to `TTCN_Runtime::executor_state' Single_main.o: In function `main': /build/eclipse-titan-5.4.1/core/Single_main.cc:178: undefined reference to `TTCN_Runtime::install_signal_handlers()' /build/eclipse-titan-5.4.1/core/Single_main.cc:179: undefined reference to `TTCN_Snapshot::initialize()' /build/eclipse-titan-5.4.1/core/Single_main.cc:180: undefined reference to `TTCN_Logger::initialize_logger()' /build/eclipse-titan-5.4.1/core/Single_main.cc:181: undefined reference to `TTCN_Logger::set_executable_name(char const*)' /build/eclipse-titan-5.4.1/core/Single_main.cc:182: undefined reference to `TTCN_Logger::set_start_time()' /build/eclipse-titan-5.4.1/core/Single_main.cc:186: undefined reference to `TTCN_Logger::log_executor_runtime(int)' /build/eclipse-titan-5.4.1/core/Single_main.cc:187: undefined reference to `Module_List::pre_init_modules()' /build/eclipse-titan-5.4.1/core/Single_main.cc:192: undefined reference to `TTCN_Logger::log_configdata(int, char const*)' /build/eclipse-titan-5.4.1/core/Single_main.cc:195: undefined reference to `TTCN_Snapshot::check_fd_setsize()' /build/eclipse-titan-5.4.1/core/Single_main.cc:198: undefined reference to `process_config_file(char const*)' /build/eclipse-titan-5.4.1/core/Single_main.cc:199: undefined reference to `TTCN_Runtime::load_logger_plugins()' /build/eclipse-titan-5.4.1/core/Single_main.cc:201: undefined reference to `TTCN_Runtime::set_logger_parameters()' /build/eclipse-titan-5.4.1/core/Single_main.cc:202: undefined reference to `TTCN_Logger::open_file()' /build/eclipse-titan-5.4.1/core/Single_main.cc:203: undefined reference to `TTCN_Logger::write_logger_settings(bool)' /build/eclipse-titan-5.4.1/core/Single_main.cc:204: undefined reference to `execute_list_len' /build/eclipse-titan-5.4.1/core/Single_main.cc:204: undefined reference to `execute_list' /build/eclipse-titan-5.4.1/core/Single_main.cc:278: undefined reference to `TTCN_Runtime::restore_signal_handlers()' /build/eclipse-titan-5.4.1/core/Single_main.cc:279: undefined reference to `TTCN_Runtime::log_verdict_statistics()' /build/eclipse-titan-5.4.1/core/Single_main.cc:281: undefined reference to `TTCN_Logger::log_executor_runtime(int)' /build/eclipse-titan-5.4.1/core/Single_main.cc:282: undefined reference to `TTCN_Logger::close_file()' /build/eclipse-titan-5.4.1/core/Single_main.cc:283: undefined reference to `TCov::close_file()' /build/eclipse-titan-5.4.1/core/Single_main.cc:287: undefined reference to `TTCN_Logger::clear_parameters()' /build/eclipse-titan-5.4.1/core/Single_main.cc:288: undefined reference to `PORT::clear_parameters()' /build/eclipse-titan-5.4.1/core/Single_main.cc:289: undefined reference to `COMPONENT::clear_component_names()' /build/eclipse-titan-5.4.1/core/Single_main.cc:290: undefined reference to `TTCN_EncDec::clear_error()' /build/eclipse-titan-5.4.1/core/Single_main.cc:293: undefined reference to `Free' /build/eclipse-titan-5.4.1/core/Single_main.cc:294: undefined reference to `Free' /build/eclipse-titan-5.4.1/core/Single_main.cc:296: undefined reference to `Free' /build/eclipse-titan-5.4.1/core/Single_main.cc:298: undefined reference to `TTCN_Logger::terminate_logger()' /build/eclipse-titan-5.4.1/core/Single_main.cc:299: undefined reference to `TTCN_Snapshot::terminate()' /build/eclipse-titan-5.4.1/core/Single_main.cc:124: undefined reference to `TCov::close_file()' /build/eclipse-titan-5.4.1/core/Single_main.cc:129: undefined reference to `TTCN_Logger::initialize_logger()' /build/eclipse-titan-5.4.1/core/Single_main.cc:130: undefined reference to `Module_List::pre_init_modules()' /build/eclipse-titan-5.4.1/core/Single_main.cc:131: undefined reference to `Module_List::list_testcases()' /build/eclipse-titan-5.4.1/core/Single_main.cc:135: undefined reference to `TTCN_Logger::terminate_logger()' /build/eclipse-titan-5.4.1/core/Single_main.cc:136: undefined reference to `TCov::close_file()' /build/eclipse-titan-5.4.1/core/Single_main.cc:149: undefined reference to `Module_List::print_version()' /build/eclipse-titan-5.4.1/core/Single_main.cc:150: undefined reference to `TCov::close_file()' /build/eclipse-titan-5.4.1/core/Single_main.cc:211: undefined reference to `execute_list_len' /build/eclipse-titan-5.4.1/core/Single_main.cc:211: undefined reference to `execute_list' /build/eclipse-titan-5.4.1/core/Single_main.cc:212: undefined reference to `Free' /build/eclipse-titan-5.4.1/core/Single_main.cc:213: undefined reference to `Free' /build/eclipse-titan-5.4.1/core/Single_main.cc:218: undefined reference to `Realloc' /build/eclipse-titan-5.4.1/core/Single_main.cc:221: undefined reference to `memptystr' /build/eclipse-titan-5.4.1/core/Single_main.cc:234: undefined reference to `mcopystr' /build/eclipse-titan-5.4.1/core/Single_main.cc:224: undefined reference to `mputstr' /build/eclipse-titan-5.4.1/core/Single_main.cc:225: undefined reference to `mputc' /build/eclipse-titan-5.4.1/core/Single_main.cc:233: undefined reference to `mcopystr' /build/eclipse-titan-5.4.1/core/Single_main.cc:240: undefined reference to `TTCN_Logger::log_configdata(int, char const*)' /build/eclipse-titan-5.4.1/core/Single_main.cc:241: undefined reference to `Free' /build/eclipse-titan-5.4.1/core/Single_main.cc:249: undefined reference to `Malloc' /build/eclipse-titan-5.4.1/core/Single_main.cc:249: undefined reference to `execute_list' /build/eclipse-titan-5.4.1/core/Single_main.cc:250: undefined reference to `mcopystr' /build/eclipse-titan-5.4.1/core/Single_main.cc:255: undefined reference to `Module_List::log_param()' /build/eclipse-titan-5.4.1/core/Single_main.cc:256: undefined reference to `Module_List::post_init_modules()' /build/eclipse-titan-5.4.1/core/Single_main.cc:258: undefined reference to `execute_list' /build/eclipse-titan-5.4.1/core/Single_main.cc:263: undefined reference to `Module_List::execute_all_testcases(char const*)' /build/eclipse-titan-5.4.1/core/Single_main.cc:266: undefined reference to `Module_List::execute_testcase(char const*, char const*)' /build/eclipse-titan-5.4.1/core/Single_main.cc:260: undefined reference to `Module_List::execute_control(char const*)' /build/eclipse-titan-5.4.1/core/Single_main.cc:260: undefined reference to `execute_list' /build/eclipse-titan-5.4.1/core/Single_main.cc:198: undefined reference to `execute_list_len' /build/eclipse-titan-5.4.1/core/Single_main.cc:269: undefined reference to `TTCN_warning(char const*, ...)' /build/eclipse-titan-5.4.1/core/Single_main.cc:269: undefined reference to `execute_list' /build/eclipse-titan-5.4.1/core/Single_main.cc:275: undefined reference to `TTCN_Logger::log_str(TTCN_Logger::Severity, char const*)' /build/eclipse-titan-5.4.1/core/Single_main.cc:273: undefined reference to `execute_list_len' /build/eclipse-titan-5.4.1/core/Single_main.cc:276: undefined reference to `execute_list' Single_main.o: In function `__static_initialization_and_destruction_0': /build/eclipse-titan-5.4.1/core/../common/version.h:94: undefined reference to `reffer::reffer(char const*)' Single_main.o: In function `JSON_Tokenizer::JSON_Tokenizer(bool)': /build/eclipse-titan-5.4.1/core/../common/JSON_Tokenizer.hh:115: undefined reference to `JSON_Tokenizer::init(char const*, unsigned long)' Single_main.o: In function `__static_initialization_and_destruction_0': /build/eclipse-titan-5.4.1/core/../common/JSON_Tokenizer.hh:164: undefined reference to `JSON_Tokenizer::~JSON_Tokenizer()' collect2: error: ld returned 1 exit status Makefile:286: recipe for target 'single-dynamic' failed make[2]: *** [single-dynamic] Error 1 uh? > > there are a bunch of debug-file-with-no-debug-symbols and that > > postinst-has-useless-call-to-ldconfig that makes me itch. I feel there > > is something weird going on, but I wouldn't know what it is. > > > > Can't find out what's this. Checked the Makefile, the standard output, but > I can't see anything related to this. > > > > > 5) > > do you even look at what lintian says on mentors? > > I: eclipse-titan source: wildcard-matches-nothing-in-dep5-copyright > > mctr2/editline (paragraph at line 5) > > I: eclipse-titan source: unused-file-paragraph-in-dep5-copyright paragraph > > at line 5 > > > > the order of the paragraphs in d/copyright is important. the wildcard > > in the second paragraph overrides the first. so you need to swap them. > > > > Switched the paragraphs, deleted unnecessary white spaces, etc... didn't > worked. > Checked every part of > https://www.debian.org/doc/packaging-manuals/copyright-format/1.0 but > nothing. No more ideas. -Files: mctr2/editline +Files: mctr2/editline/* does the trick :) Yes, DEP-5 can be really picky sometimes! You also have a trailing whitespace at line 40 of that file. while doing small changes, the --verbose flag is not needed if you use DH_VERBOSE (which is more comprehensive, e.g. the override wouldn't be aware of the --verbose flag of dh). Also, --verbose is not really used and known, compare to DH_VERBOSE. So, can you please remove --verbose from the dh invocation? > > Furthermore I don't see a paragraph for debian/, as I can read it now > > the copyright for debian/* is of "Ericsson Telecom AB". > > > > Is this a problem? I'm working at Ericcson, and I'm doing it as part of my > job. :) nah, that's totally fine, I'm just not used to it so it looked weird to my eyes :) -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
