(moving discussion to RFS bug, please keep me in CC) On 1 December 2015 at 11:15, Roger Shimizu <rogershim...@gmail.com> wrote: > Dear Felipe, > > Considering now we have consensus on the service file except the > description part, which is quite minor, I made a release build of > adjtimex package and uploaded to mentors.
OK > > I also created a RFS: https://bugs.debian.org/806797 > > Since you helped me greatly on the service file, which is the most > significant improvement of this version (adjtimex/1.29-6), I hope you > can kindly be my sponsor to upload. Thank you! Sure! I have a few comments, though: - uscan tells me that there is no 1.29 version in the upstream page. And indeed there is only 1.28. What happened? - It would be great if you forward your patches upstream. - The dirs file is not needed. It is only useful when a package needs to ship a directory that is not created by anything else in the build process. In your case, all directories are created by either the upstream build system or the debhelper commands. - I would change all /bin/sh -e in maintainer scripts to use #!/bin/sh\nset -e. This way, if it is invoked via `sh $script`, then it will still get the -e option. Otherwise looks good -- Saludos, Felipe Sateler
