Control: owner -1 ! Control: tags -1 moreinfo
Hi Daniel, first review: 1) please merge the changelogs in a single entry, because seems that 4.2.1 never hit unstable 2) priority: extra, I guess it is better suitable for optional https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities (at least mention in the copyright why you changed that) 3) VCS fields, please uncomment them and create the collab-maint repo (if you have troubles please tell me) I would appreciate if you could add also all the previous releases with something like gbp import-dscs --debsnap git-import-dsc --pristine-tar packagename (note: I didn't try the above) 4) please mention changes e.g. bump of std-version, bump of debhelper and compat leve, add of a new build dependency and so on 5) CMakeLists.txt is *not* a doc AFAIK, why you did add it? 6) bonus point if you convert the rules file with the new dh style e.g. why do you create a build dir? 7) debian/source/include-binaries, please remove 8) debian/info and debian/docs, are they useful this is a rules file that looks better to me %: TAB dh $@ --parallel override_dh_auto_configure: TAB dh_auto_configure -- -D CMAKE_BUILD_TYPE=Release \ TAB -D CMAKE_INSTALL_PREFIX=/usr/ \ TAB -D XTRKCAD_USE_GETTEXT=ON \ TAB -D XTRKCAD_USE_GTK=ON \ TAB -D XTRKCAD_USE_GTK_CAIRO=ON \ TAB -D XTRKCAD_USE_LAYOUTCONTROL=ON ../ override_dh_install: TAB dh_install TAB rm -f debian/xtrkcad/usr/share/xtrkcad/COPYING override_dh_installman: TAB dh_installman debian/xtrkcad.1 (you can also create a packagename.manpages with "debian/xtrkcad.1" as entry, to avoid the two above lines) please run a debdiff between the two .deb files to see if the new dh is making something differ in installation and now the bad part copyright: some licenses are missing: e.g. app/bin/bitmaps/SVG/tipofday.svg + <ns:license + rdf:resource="http://creativecommons.org/licenses/publicdomain/"; /> + <dc:contributor> app/bin/cblock.c seems to be GPL-2+ also app/bin/cswitchmotor.c i18n.* stripmsg.c well, seems that they switched to GPL-2+ from GPL-2 the other stuff looks good to me, even if they are some compilation warnings and check-all-the-things reports: codespell --quiet-level=3 (so much) cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.'(much stuff) find -type f -iname '*.desktop' -exec desktop-file-validate {} \; ./debian/xtrkcad.desktop: error: value "train;railroad;cad;model" for locale string list key "Keywords" in group "Desktop Entry" does not have a semicolon (';') as trailing character ./debian/xtrkcad.desktop: error: value "Graphics" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character ./app/lib/xtrkcad.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated ./app/lib/xtrkcad.desktop: error: value "Application;Railroad;Game" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character grep -Er '/(home|srv|opt)(\W|$)' . (lots) find -type f ! \( -iname '*.blend' -o -iname '*.icns' -o -iname '*.bmp' -o -iname '*.ico' -o -iname '*.png' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' -o -iname '*.tga' -o -iname '*.xcf' -o -iname '*.mo' -o -iname '*.gmo' -o -iname '*.gz' -o -iname '*.bz2' -o -iname '*.xz' -o -iname '*.lz' -o -iname '*.zip' -o -iname '*.tar' -o -iname '*.deb' -o -iname '*.pdf' -o -iname '*.odt' -o -iname '*.docx' -o -iname '*.doc' -o -iname '*.torrent' -o -iname '*.pyc' -o -iname '*.pyo' -o -iname '*.o' -o -iname '*.so' -o -iname '*.so.*' -o -iname '*.debug' -o -iname '*.wav' -o -iname '*.ogg' -o -iname '*.oga' -o -iname '*.ogv' -o -iname '*.mid' -o -iname '*.ttf' -o -iname '*.otf' -o -iname '*.fon' \) -exec isutf8 {} + (lot) you might want to fix some of them, while all of them needs upstream forwarding) cheers, G.
