Hi Gianfranco, Thanks for the review.
All have been fixed as instructed. Ref https://github.com/suntong/shc-build/commits/master And new build is uploaded to http://mentors.debian.net/package/shc The respective dsc file can be found at: http://mentors.debian.net/debian/pool/main/s/shc/shc_3.8.9b-1.dsc Thanks On Fri, Sep 25, 2015 at 7:44 AM, Gianfranco Costamagna <costamagnagianfra...@yahoo.it> wrote: > Control: owner -1 ! > > > Hi, lets review: > > changelog: please be more verbose: e.g bump std-version, > -add patches > -remove patches > -refresh patches > -drop README.source > > > > changelog: > -shc (3.8.7-2) unstable; urgency=medium > > +shc (3.8.7-2) unstable; urgency=low > > > well your previous uploader uploaded with medium instead of low, please adapt > the changelog accordingly > > copyright: > please update copyright years > > patches: > they might be upstreamed, but maybe please use something like > "?=" instead of "=" that way they will be assigned only if not already > assigned > > http://stackoverflow.com/questions/448910/makefile-variable-assignment > > the other patches should be upstreamed IMHO. > > cheers, > > G.
