Am Mittwoch, den 23.09.2015, 10:33 -0400 schrieb Bill Blough: > Thanks for your review. > > I normally use uscan, so I haven't really thought about get-orig > -source. But > it seems like a good idea- I'll look into adding it. > > As for sf.net vs github, the project is in the process of changing > hosting. > The old repo has commits disabled and all new development is being > done on > github. I expect the website links will be updated eventually. > > Thanks again. > > Bill > > On Tue, Sep 22, 2015 at 10:45:35PM +0300, Eugene Zhukov wrote: > > Hi, > > I took a peek and didn't find get-orig-source in d/rules. d/watch > > has link to > > github, while pwsafe.org links to sourceforge. > > >
Hi Bill, - d/source/options: Why do you have the option diff-ignore? - d/patches are marked as Forwarded: no and not-needed. Are they really not upstreamable? - please use wrap-and-sort; this will also remove those trailing whitespaces I love to nitpick about... - Well, README.LINUX does not really have information for the user beside it's beta, so I'd not install it but explain in the package description that not all features are implemented - I would not install both the html and txt version of docs/ReleaseNotes, they have identical content. Also, this seems to be the project's changelog, so it should be installed with dh_installchangelog and not via dh_installdocs. Therefore it should also not be registered using doc-base - d/menu should be depreciated in favour of .desktop files, so remove this file. See also #741573 - the chm file you refer in your source override -- I guess it is not built at build time. We need to build everything from source... Can you simply remove it? That's how far I come... Will continue as soon as possible -- tobi
