(replying just to the issues I raised) On 2015-09-15 21:00, Geoff wrote: >> - It is helpful to be more explicit about some changes. You mention, >> for example, that the package has been converted to Python 3. The >> fact that the Python 2 package has been dropped is merely implied. >> That is IMHO a significant change, and should be worth a hint > Indeed, though, this is not a python module but only an application.
Oh, my bad! Sorry about that. (Hence also why I hadn't posted my notes earlier -- the review was still somewhat rough) >> d/NEWS: >> - The upgrade path suggestion for the conffile in /etc isn't >> really the prettiest solution, although I really don't know what >> other path I could suggest that wouldn't seem like overkill. How >> did upstream handle this change? Do they perhaps have a script or >> tool that could assist in this process? > > Well, I'm actually upstream, I did not write any tool to migrate the > conf. Oh -- another thing I seem to have missed. > Since the package is not that popular (popcon ~ 100) and because > target users are quite probably advanced users and command line lovers, > I did not try to handle a nice and smoothly conf upgrade. > > Well I think the current tradeoff to be acceptable given the package > popularity and users profile. I believe you are right. After all, you are preserving possible user changes to the conffile, in accordance with the Policy. Regards, Christian
signature.asc
Description: OpenPGP digital signature
