Gianfranco Costamagna <costamagnagianfra...@yahoo.it> wrote:
> the packaging looks mostly good.
>
> Just a few questions:
> python-setuptools (>= 0.6b3),
>
> the version is already satisfied in old old stable, you can remove it.
Done.
> setup.py
>
> install_requires"jinja2 >=2.5",
> "django >=1.4",
>
> they aren't listed in B-D, so they won't be picked up on the package during
> installation
> with python{,3}:Depends
Done.
> tests_require = [
> "pytz",
> ],
>
> running testsuite might be good during the build.
The testsuite isn't included in the distribution tar file generated by
upstream. I filed an upstream github but to include the testsuite:
https://github.com/niwinz/django-jinja/issues/135
--
Edward.
