PS: Just find out it is the debugging symbol taking all that space, so I re-enable the stackprotector.
2015-08-12 16:11 GMT+08:00, Alex Vong <alexvong1...@gmail.com>: > Hi Jean-Michel, > > Thanks for reminding me that overriding isn't safe. > > Now I use `DEB_BUILD_MAINT_OPTIONS = hardening=-stackprotector' to > remove `-fstack-protector-strong' since it makes the binary 10 times > the size without the flag. The DEB_*_MAINT_* seems like a better way > to manipulate flags since new flags can be added without me doing > anything as you said. Maybe Lintian should add a new warning: > Overrding *FLAGS in debian/rules. > > Cheers, > Alex > > 2015-08-11 23:12 GMT+08:00, Jean-Michel Vourgère <nir...@debian.org>: >> Alex Vong wrote: >>> Maybe overriding CFLAGS and CPPFLAGS but not LDFLAGS will solve FTBFS. >>> >>> For example in debian/rules, >>> >>> CFLAGS = '-Ofoo' >>> CPPFLAGS = '-Dfoo' >>> LDFLAGS += '-lfoo' >>> >>> override_dh_auto_configure: >>> dh_auto_configure -- --enable-foo >> >> This is wrong. You should *not* overwrite default CFLAGS / CPPFLAGS and >> so on. This is precisely what usually results in poor hardening. Just >> imaging what will happen if tomorrow there is a new flag to set? >> >> If you really need to add some stuff, you can use >> DEB_CFLAGS_MAINT_APPEND, and similar. See dpkg-buildflags(1). >> >> >> -- >> To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org >> with a subject of "unsubscribe". Trouble? Contact >> listmas...@lists.debian.org >> Archive: https://lists.debian.org/55ca10f6.2090...@debian.org >> >> > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CADrxHD-sB9_0CG=ttykpkzagkykhzq4wepjxueo51vj2fsw...@mail.gmail.com
