Hello Gianfranco and thank you for your review, > 1) d/changelog: please update the changelog to point to unstable suite > (maybe also refresh the timestamp)
Ok. > 2) d/changelog might benefit of a "\n" in the first comment line > (after a full stop it is good to go in a new line) Ok. > 3) d/copyright file lists twice GPL-2+ licensethis isn't a problem, but you > can do something like > > License: GPL-2+ > [snip] > License: GPL-2+ > and at the end > License: GPL-2+ > [license text] Ok. > 4) d/copyright: you should add yourself to the copyright file, since you are > going to work > on the packaging of qemuctl Ok. > 5) d/control: what about team maintaining the tool and setting you as > uploader? > pkg-qemu-devel team might want to have that package under the team umbrella > https://qa.debian.org/developer.php?login=pkg-qemu-de...@lists.alioth.debian.org Not changed yet, but inquiry sent to http://lists.alioth.debian.org/cgi-bin/mailman/private/pkg-qemu-devel/2015-August/006604.html so if they have good suggestions, then one more upload to mentors will be needed. > 6) d/watch file: you might want to use the Debian redirector instead of > pointing directly to sf > https://qa.debian.org/cgi-bin/fakeupstream.cgi?upstream=sf/qemuctl Ok, didn't know such thing was in place. Qemuctl is not listed in re-director so adding it there would require another ticket into BTS. To avoid this hassle, I'm leaving the current URL because it is working ok with uscan. > 7) d/rules,d/clean: instead of override_dh_clean you might want to create a > debian/clean, and add > "debian/qemuctl.1" as content, to save some bits in your rules file Ok. > 8) d/rules: you might want to remove lines from 3 to 8, they are autogenerated Ok. > 9) d/rules, please add > export QT_SELECT=4 > because otherwise compilation might fail if you have both installed in your > system Ok. > 10) d/*.lintian-overrides: I see twice the lintian override > > "no-upstream-changelog", are you sure it is needed for both binary and source > packages? > (note: I didn't check this) https://lintian.debian.org/tags/no-upstream-changelog.html seems to suggest it makes sense only with binary package. So removed from source package and lintian is not causing trouble. There is now a new version uploaded to mentors that includes the changes described above. The source package can be obtained using dget -x http://mentors.debian.net/debian/pool/main/q/qemuctl/qemuctl_0.3.1-4.dsc -- Antti Järvinen -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/21958.31649.852888.276...@muikku.katiska.org
