Hi Rodolphe, On Sat, May 16, 2015 at 1:23 PM, Rodolphe PELLOUX-PRAYER <rodol...@damsy.net> wrote: > Hi Vincent, > > Thx for your review! > >> debian/copyright is missing a few entries: >> - src/serial/*: Copyright 1997-2001 John E. Stone (j.st...@acm.org), >> 3-clause BSD (+ upstream author) > > Should be fixed.
You're also missing Thomas Anderson <t...@nextgenengineering.com> as the copyright holder for a number of files in src/magellan/. (In case you haven't done so already, please take the time to do a thorough license/copyright check yourself when adopting/packaging new packages.) >> debian/stamp-patched is useless and can be removed. > > Done. > >> debian/patches/run.patch is rather redundant; /var/run is not going to >> be removed from Debian in the foreseeable future and will likely be >> kept around for compatibility reasons for a long time. If you do >> decide to keep it though, please look into adding DEP-3 [1] headers >> for it (and any future patch you add). > > As it is not too invasive, I choose to keep it, I just added a simple > header. Ok. >> Your package isn't actually hardened. "export DEB_BUILD_MAINT_OPTIONS >> = hardening=+all" in d/rules isn't going to do anything if your >> package's build system ignores the hardening flags set by >> dpkg-buildflags. > > Right, I have seen this but I did not know how to deal with. I plan to > propose an update build system (cmake) to upstream dev but for now, I > added a debian specific patch. That's fine. By the way, I also suggest that you use start-stop-daemon in your sysvinit script, especially since you're shipping a script of your own here. Regards, Vincent -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CACZd_tCLFotzUgXPygnhZorQ_NAdtLmDZ1=pzzn2sois8tt...@mail.gmail.com
