On 12 May 2015 at 20:29, Andrey Rahmatullin <w...@debian.org> wrote: > [I don't intend to sponsor this] > > You should put the Debian repo, not the upstream one into Vcs-* control > fields. >
Thanks, fixed. > Recommending both screen and tmux looks strange. Recommending acpi which > is useful only for laptops looks strange too. Suggesting zsh looks wrong. > I've donwgraded acpi from Recommends to Suggests. I've deleted zsh from Suggests. liquidprompt uses screen and tmux to obtain information (optionally). How would you declare them if not in Recommends? > d/copyright misses a section for debian/* > Thanks, fixed. > AGPL-3 should probably be AGPL-3+. > Thanks, fixed. > I don't like the idea of "multiple invocations of the > liquidprompt_activate command may pollute ~/.bashrc and/or ~/.zshrc files" > even if it's mentioned in the manpage. Well, it's just a shortcut, to ease the installation to the users. I know this is a bit ugly, but I guess it's better than nothing (or manually editing these files). Given that the user may edit by hand the ~/.bashrc file and load liquidprompt in another way, detecting if it has been previously activated can't be done easily. Of course, this point can be improved in the future. > > I think a manpage in the section 1 is expected to correspond to an > executable with the same name which is not the case here. Maybe I am wrong > here. Well, there is a binary called `liquidprompt_activate' and a link. So, an user typing: `man liquidprompt' and `man liquidprompt_activate' will go to the same manpage, which briefly documents the basics of liquidprompt (including liquidprompt_activate). Thanks for your review. I've uploaded to mentors de updated package. -- Arturo Borrero González -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CAOkSjBhJZEquRZM4pitYF69JDizJ-mAAj9gdQB+g5r=kmtd...@mail.gmail.com
