Thanks for the review :-)
On 02/04/15 19:47, Sebastiaan Couwenberg wrote:
Hi Ross,
Thanks for your work on this package.
On 04/01/2015 08:53 PM, Ross Gammon wrote:
I am looking for a sponsor for my package "node-convert-source-map"
There are some minor issues that needs to be addressed before the upload
to the archive.
debian/control:
Testsuite: autopkgtest
AFAIK this is not an official header yet, it should be XS-Testsuite.
Fixed. I am still fine tuning my set up on the new Jessie laptop. cme
fix dpkg-control got more things correct than I am used to on my desktop
machine, but I clearly cannot completely trust it!
debian/copyright:
It contains an incorrect copyright year, npm2deb tends to get this
wrong. The LICENSE file specifies 2013.
Fixed.
The upstream sources contain an example, you should consider including
it in the package.
Added a node-convert-source-map.examples file.
Since inline-source-map is not packaged yet, you can't run the tests. If
it get packaged in the future you should consider running the tests
during the build process.
Added a d/TODO file to remind me to check if the tests can be enabled
next time.
Kind Regards,
Bas
Updated on alioth & uploaded fresh to Mentors.
Regards,
Ross
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/551ea801.4040...@mail.dk
