On Tue, 31 Mar 2015 19:35:12 Etienne Millon wrote: > I am looking for a sponsor for my package "opentyrian"
That is very nice. I was looking forward to see opentyrian in Debian for a while. Thanks for packaging. > I'm happy to hear your remarks about this package. First thing to improve is to add more DEP-3 [1] headers to patches. Specifically the following (missing) headers would be useful: Forwarded Last-Update Origin Applied-Upstream Working with upstream is important part of package maintenance. From looking at patch headers I need to see whether it was Forwarded, when Last-Update happened, where patch was taken from (Origin, if it was borrowed from upstream or from another distro) and sometimes Applied-Upstream status. If you did not forward patches yet I'd recommend to wait no further and document progress as described. Also there are some remarks about packaging: * There should be versioned Depends on "game-data-packager" which actually support "tyrian-data" (i.e. "tyrian-data | game-data-packager (>= 40)"). * Package should install icon (there are some in "linux/icons). Icon is referenced from installed .desktop file. * Repository do not match package uploaded to Mentors. There are differences in "control" (Standards-Version) and in README.Debian. * Why not enable full hardening? (e.g. "export DEB_BUILD_MAINT_OPTIONS = hardening=+all") * Re-distribution of pre-built binary "macosx/tyrian.icns" in source archive may be a bit of concern. * There is a comma "," which is not present in the original copyright statement after copyright year in ~~~~ Files: ./src/video_scale_hqNx.c Copyright: 2003, MaxSt ( ma...@hiend3d.com ) ~~~~ IMHO it should be just "2003", not "2003,". Other than this "debian/copyright" looks good. > Also, please note > that I'm a Debian Maintainer, so once this clears NEW I'm interested > in uploading the next revisions myself. Thanks! Great attitude. :) [1]: http://dep.debian.net/deps/dep3/ -- Cheers, Dmitry Smirnov GPG key : 4096R/53968D1B --- The truth is incontrovertible, malice may attack it, ignorance may deride it, but in the end; there it is. -- Winston Churchill
signature.asc
Description: This is a digitally signed message part.