-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello Mateusz,
I noticed your RFS-ticket and tried conducting a review on it. I'm no
DD so I can't submit your package further but maybe this is useful for
future reviewers.
Packaging looks really good to me. Some questions I have
- debian/darkhttpd.default assumes existence of user-account "www-data"
but is there method to ensure that www-data is found in /etc/passwd?
Maybe something into postinst script?
- debian/darkhttpd.postrm is there need to remove config files
with if [ "$1" = purge ] ; ... ?
This is kind of personal feeling but I'd like the "remove" to
leave configs and "purge" to leave no trace, /etc/default/darkhttpd
might fall into this category maybe.
- in debian testing amd64 hw the install goes like this:
# dpkg -i darkhttpd_1.11-1_amd64.deb
Selecting previously unselected package darkhttpd.
(Reading database ... 555944 files and directories currently installed.)
Preparing to unpack darkhttpd_1.11-1_amd64.deb ...
Unpacking darkhttpd (1.11-1) ...
Setting up darkhttpd (1.11-1) ...
Job for darkhttpd.service failed. See 'systemctl status darkhttpd.service'
and 'journalctl -xn' for details.
invoke-rc.d: initscript darkhttpd, action "start" failed.
dpkg: error processing package darkhttpd (--install):
subprocess installed post-installation script returned error exit status 1
Processing triggers for man-db (2.7.0.2-5) ...
Errors were encountered while processing:
darkhttpd
status.darkhttpd.service reveals that
~ darkhttpd.service
Loaded: not-found (Reason: No such file or directory)
Active: failed (Result: exit-code) since su 2015-03-29 22:33:55 EEST;
2min 11s ago
maalis 29 22:33:55 fisuvaan darkhttpd[13392]: darkhttpd: opening logfile:
fopen("/var/log/darkhttpd/access.log"): No such file or directory
maalis 29 22:33:55 fisuvaan darkhttpd[13392]: darkhttpd/1.11, copyright (c)
2003-2015 Emil Mikulic.
maalis 29 22:33:55 fisuvaan darkhttpd[13392]: listening on:
http://0.0.0.0:80/
maalis 29 22:33:55 fisuvaan systemd[1]: darkhttpd.service: control process
exited, code=exited status=1
maalis 29 22:33:55 fisuvaan systemd[1]: Failed to start Darkhttpd Webserver
daemon.
maalis 29 22:33:55 fisuvaan systemd[1]: Unit darkhttpd.service entered
failed state.
maalis 29 22:35:27 fisuvaan systemd[1]: Stopped Darkhttpd Webserver daemon.
Is it so that while testing your scripts you maybe have had a
file or directory that my box is missing?
+ On bonus-side, the binary works if I start the daemon from command-line
and it even serves me pages no problem.
- --
Antti Järvinen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>
iD8DBQFVGFY/UTdja+nNMWMRAjWfAKCGsIZxqDxry75XgO3kU7yddSYl4gCfWb6R
8TQtlpIO9opPetuwA4AYL0g=
=m8VJ
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/21784.22103.924858.166...@muikku.katiska.org
