マイリノデイヴィッド <maiorinoda...@gmail.com> writes: > Bug#775509: RFS: tz-converter/1.0.0 ITP tz-converter Hello Dave!
Thank you for your contribution to Debian. I'm not able to sponsor your package, but I took a look at it to see if there were things you could fix while you wait. (Some of these problems would traditionally be forwarded upstream and patched in Debian, but since you are also the upstream maintainer, a new release might be easier.) The most pressing concern to me is that the source for the two images included as icons is unclear. While the .ico file is referenced in d/copyright, including its source as a note is probably a good idea. The gnome-set-time.png icon has no listed license and should probably include the vector version if it is supplied by upstream - as the vector is the "preferred form of modification". This must be fixed before someone will sponsor it. The build directory should be removed from the upstream tarball. It's just duplicate code, and it gets removed by debhelper when the build is actually run anyway. pep8 shows a bunch of code formatting errors - mostly lines being too long and a couple of whitespace errors. You may be able to use a tool like autopep8 to correct the errors, though I suggest looking through the diff that it produces in case it does something wonky. Because you are both upstream and the Debian maintainer for the package, you should install the changelog file as changelog.gz, rather than changelog.Debian.gz. Take a look at Debian Policy 12.7 for more information. Thank you again for your contributions to Debian; I'm happy to take a second look after you have fixed these problems. Sincerely, -- Harlan Lieberman-Berg ~hlieberman -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/871tkafero....@setec.io
