On Mon, Mar 9, 2015 at 7:51 AM, Peter Spiess-Knafl wrote: > To: sub...@bugs.debian.org, Paul Wise <p...@debian.org>
Please use an X-Debbugs-CC pseudo-header in the mail body instead in future: https://www.debian.org/Bugs/Reporting#xcc > I am looking for a sponsor for my package "codespell" The debian/upstream/upstream file is incorrectly named. The patch isn't the right way to override the default prefix. Please replace it by changes to debian/rules (override_dh_auto_build) if debhelper isn't already passing the right prefix. override_dh_auto_build: dh_auto_build -- prefix=/usr Did you review the changes to policy since 3.9.5? Were any changes needed? Please mention in debian/changelog if no changes were needed. https://www.debian.org/doc/debian-policy/upgrading-checklist I would suggest wrapping the URL and regex on different lines in debian/watch, you can use the line continuation character (backslash) to do that. The file debian/codespell.1 is an automatically generated file, all automatically generated files should be created at build time and not be present in version control systems or upstream tarballs, otherwise they will get out of date. Please add a command to debian/rules to generate it after dh_auto_build. The file debian/codespell.1 contains an incorrect path to the dictionary as it seems you created it using codespell.py instead of codespell, which has the right path after it is generated from the codespell.py script. /tmp/codespell/codespell\-1.7/data/dictionary.txt Are you really working on code in /tmp? I'd strongly suggest working in /home instead since /tmp is world-writable. Upstream has added a check target in the Makefile so the override_dh_auto_test target can be removed from debian/rules. You appear to have forgotten to close #779900 in debian/changelog. #763266 is marked as fixed-upstream, did 1.7 fix it? If so you will want a debian/changelog entry like this: Please run tagpending (from devscripts) when uploading to mentors. Thanks for adopting codespell! Automatic checks: $ cme check dpkg ... Warning in 'patches:"0001-fix-install-prefix.patch" Synopsis' value <undef>: Empty synopsis (code is: 'defined $_ && /\w/ ? 1 : 0 ;') $ find -type f -iname '*.asc' -exec cat {} + | hot dearmor | hokey lint ... Self-sig hash algorithms: [SHA1] https://help.riseup.net/en/security/message-security/openpgp/best-practices#self-signatures-should-not-use-sha1 $ pep8 --ignore W191 . <lots of messages> -- bye, pabs https://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/caktje6f_coy-otxmf_pwdeih6z7kbkgwtw0etau5_0t25w9...@mail.gmail.com
