On 03/03/2015 09:33 PM, Sebastiaan Couwenberg wrote: >> * Fix duplicate package descriptions > > You may want to tweak these a bit to be more in line with other node-* > and libjs-* packages. > > See for example node-q: > > http://anonscm.debian.org/cgit/pkg-javascript/node-q.git/tree/debian/control > > And also what npm2deb generates. > > I pushed a change with my suggested improvement. >
Changes looked good - will double check later tonight. >> * Remove async.js and use packaged version instead > > This looks a lintian false positive, the async.js in bluebird is quite > different from the node-async one. > > Compare: > > http://anonscm.debian.org/cgit/pkg-javascript/node-async.git/tree/lib/async.js > > http://anonscm.debian.org/cgit/pkg-javascript/node-bluebird.git/tree/src/async.js > > I think reverting this change and adding a lintian override instead is a > better idea. Whoops - I should of checked that. I was in a hurry to finish - that is never a good thing. I have a few family commitments tonight, but after that I will fix. Cheers, Ross
signature.asc
Description: OpenPGP digital signature
