Control: tags -1 moreinfo Am Donnerstag, den 19.02.2015, 10:04 +0100 schrieb Tobias Frost: > Hi Sebastien, > > Thanks for adopting the package. I will sponsor your upload. > (However, I cannot do it now, but I will do a througouh review tonight or > tomorrow) > > Some first remarks: > -> I recommend to avoid uploading a new upstream version to sid during the > freeze. Use experimental. > -> please integrate get-orig-source.sh into d/rules if it is still required > (is > the new source now DFSG compliant? If so, document that in the changelog!) > -> please update d/rules to short debhelper format > -> please upgrade to debhelper compat level 9 > -> please cleanup d/patches for patches applied upstream > and check if not-forwarded patches should be forwarded > -> you can drop the B-D version constraint on dpkg-dev -- even oldstable > fulfilles it > -> can you please check if the override for conflicts-with-version is valid? > (I did not check the details, > so this could be wrong; it just smells like you want to have Replaces: and > Breaks: here, see Policy 7.6.1) > If you do a change here, be sure to properly test this.
Ok, continuing... -> please document every change in d/changelog. For example, the change in the patch no-task-rel.patch is not documented (there are more, non mentioned changes on the patches) -> (for clarifaction of above: with cleanup patches I mean delete old patches no longer needed.) -> the upstream tarball is not identical with yours. -> You say "tasksh is now a separate project and no longer included in this package" -- does this need a NEWS.Debian file (refer to Developer Reference 6.3.4) -> do you really need tar-ignore in debian/source/options? When building with debuild, the build hangs after while: (However, in pbuilder it builds) (...) [ 98%] make[4]: Entering directory '/home/tobi/workspace/deb/mentors/task/task-2.4.1/obj' make[4]: Nothing to be done for 'test/CMakeFiles/eval.t.dir/build'. make[4]: Leaving directory '/home/tobi/workspace/deb/mentors/task/task-2.4.1/obj' /usr/bin/cmake -E cmake_progress_report /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj/CMakeFiles 42 Built target variant_xor.t [100%] Built target eval.t /usr/bin/make -f test/CMakeFiles/test.dir/build.make test/CMakeFiles/test.dir/depend make[4]: Entering directory '/home/tobi/workspace/deb/mentors/task/task-2.4.1/obj' cd /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tobi/workspace/deb/mentors/task/task-2.4.1 /home/tobi/workspace/deb/mentors/task/task-2.4.1/test /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj/test /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj/test/CMakeFiles/test.dir/DependInfo.cmake --color= Scanning dependencies of target test make[4]: Leaving directory '/home/tobi/workspace/deb/mentors/task/task-2.4.1/obj' /usr/bin/make -f test/CMakeFiles/test.dir/build.make test/CMakeFiles/test.dir/build make[4]: Entering directory '/home/tobi/workspace/deb/mentors/task/task-2.4.1/obj' cd /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj/test && ./run_all --verbose # /home/tobi/workspace/deb/mentors/task/task-2.4.1/test/abbreviation.t Bottom line it does not look bad. However, please use this opportunity to create a state-of-the-art package and especially look at the DFSG change. Let me know what you think about the points. -- tobi
signature.asc
Description: This is a digitally signed message part
