Hi Johan,
Sorry for not doing this sooner, but I have reviewed the package now.
Some comments follow.
The copyright file only documents the upstream copyright, documenting
the copyright & license for debian/* is a good idea unless you want to
assign the copyright to MapBox.
There seems to be an issue with the setup.py and Python 3.2, the package
fails to build because the clean target fails before even starting the
build:
running clean
removing
'/home/bas/git/pkg-grass/python-cligj/.pybuild/pythonX.Y_2.6/build' (and
everything under it)
'build/bdist.linux-x86_64' does not exist -- can't clean it
'build/scripts-2.6' does not exist -- can't clean it
I: pybuild base:170: python3.2 setup.py clean
File "setup.py", line 12
description=u"Click params for GeoJSON CLI",
^
SyntaxError: invalid syntax
E: pybuild pybuild:256: clean: plugin distutils failed with: exit
code=1: python3.2 setup.py clean
dh_auto_clean: pybuild --clean -i python{version} -p 3.2 --dir .
returned exit code 13
make: *** [clean] Error 13
debuild: fatal error at line 1358:
couldn't exec fakeroot debian/rules:
gbp:error: Couldn't run 'debuild -d clean': debuild -d clean returned 2
This is on one of my wheezy systems, the package builds fine with Python
3.4 on sid.
lintian reports a duplicate short description. Because the short
description is already 60 characters long this doesn't leave much room
to add something like "Python 3 module for ...". Appending "for Python
V" would fall within 80 characters, although the line length including
field name exceeds it.
Kind Regards,
Bas
--
GPG Key ID: 4096R/E88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/54beb41b.5060...@xs4all.nl
