Hi Vincent,
Thanks for the detailed review! I will take care of it (I am currently
at a conference so
it may take a couple of days). I will probably have to get back to you
with some questions.
Best regards,
Michel
Vincent Legout wrote:
Hi Michel,
Michel Van den Bergh <michel.vandenbe...@uhasselt.be> writes:
I am looking for a sponsor for my package "gnucheese"
I'd be glad to sponsor your package, but I have a few comments
first. Could you please fix them and I'll upload gnucheese.
- I can't download the tar.gz from your website (permission error):
http://hardy.uhasselt.be/GnuCheese/gnucheese-1.00.tar.gz
- You missed the gtb directory in the debian/copyright file. You need to
include it even if gnucheese is not using it at buildtime. But why
include it in the tarball in the first place? See for example this
wiki page for why including third-party libraries is not recommended:
https://wiki.debian.org/UpstreamGuide#No_inclusion_of_third_party_code
- AUTHORS doesn't match debian/copyright
- pgheader.c has a MIT license
- You can remove debian/README.Debian and debian/README.source. And I
think also debian/doc, because NEWS and README are automatically
picked by dh_installdocs. And as NEWS and TODO are empty, I'd say you
can remove them from the upstream tarball.
- This lintian info tag could be fixed, just remove the comments in
debian/watch:
I: gnucheese source: debian-watch-contains-dh_make-template
- You can also remove the comments in debian/rules
- I see you commented the Vcs-* fields in debian/control. You can join
the collab-maint group on alioth.debian.org if you want to maintain
the package there. Otherwise, I'd say you can remove those 2 lines.
- In Build-Depends, you shouldn't need flex and perl. And libgaviotatb1
can also be removed, you only need to Build-Depends on the -dev
library.
- I cannot build it, ./configure fails. There is a problem with the
system gtb library. It builds fine if I remove --with-builtin-gtb=no
however. But this should be fixed because the Debian package shouldn't
be built with the embedded copy of gtb.
- It can't be built twice in a row because gnucheese.man is created
during the build. You can remove this file by adding it into
debian/clean.
- These 2 lintian tags can be fixed:
gnucheese: spelling-error-in-binary usr/games/gnucheese diplay display
gnucheese: description-synopsis-might-not-be-phrased-properly
To fix the second one, removing the capitalized M at the beginning of
the short description should be enough.
- I have this message when lauching gnucheese:
Can't open gnuchess.bin
Unable to find a polyglot book...
while I have gnuchess-book installed. Where does it look for
gnuchess.bin?
Thanks,
Vincent
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/54860af0.5040...@uhasselt.be
