On 11/22/2014 12:40 AM, Johan Van de Wauw wrote: > Feel free to review and/or sponsor. > In case you wonder, I have disabled the python3 package because there > are a lot of problems when using LANG=C . I may add support later if > python3-click has a solution.
Your package looks good in general, I have only two minor improvements to suggest. You may want to specify the supported Python version in the control file in the X-Python-Version field. https://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html#s-specifying_versions Because uscan uses the tags on Github, it's recommended to mangle the filename to not download 'v<version>.tar.gz' like it does now: -- Successfully downloaded updated package 0.15.1.tar.gz -- Successfully symlinked ../0.15.1.tar.gz to ../rasterio_0.15.1.orig.tar.gz. I suggest to use the attached watch file, which results in: -- Successfully downloaded updated package rasterio-0.15.1.tar.gz -- Successfully symlinked ../rasterio-0.15.1.tar.gz to ../rasterio_0.15.1.orig.tar.gz. Other than the above it looks like a pretty straight forward Python package. I suggest you email Francesco directly to ask for sponsorship because Andreas is currently unavailable. Kind Regards, Bas -- GPG Key ID: 4096R/E88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
version=3 opts="dversionmangle=s/\+(debian|dfsg|ds|deb)\d*$//,\ uversionmangle=s/_/./g;s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha|b|a)[\-\.]?\d*)$/$1~$2/,\ filenamemangle=s/(?:.*?)?v?(\d[\d\.]*)\.tar\.gz/rasterio-$1.tar.gz/" \ https://github.com/mapbox/rasterio/releases \ (?:.*/)*(?:rel|v|rasterio|)[\-\_]?(\d[\d\-\.]+)\.(?:tgz|tbz|txz|(?:tar\.(?:gz|bz2|xz)))
