2014-09-27 21:31 GMT-03:00 Shawn Sörbom <sh...@sorbom.com>: > Hi Eriberto,
Hi, > Regarding your list: > 1. I don't understand whats wrong here. I checked another changelog just to be > sure: > http://metadata.ftp-master.debian.org/changelogs/main/e/e3/unstable_changelog > My entries are all associated with the same upstream version. > I changed all "unstable" references to "UNRELEASED" > What else am I doing wrong? This is your first upload of the package. You need to use a -1 revision. You needn't describe each change in first upload because it is unreleased and haven't a difference from a previous version. > 6. The reference to a symlink was deliberate. The license associated with > those files was a bit ambiguous. I did not realize this would cause a lintian > error, as it did not show up when I ran checks on my machine. > I use the command `lintian -IE` to run checks. Is this error considered bad? Please, use the GFDL-1.2 to solve the problem. It isn't an ideal situation because the upstream should have declared the version to be used. But we have a copyright notice and you need list all authors. Is wrong to use a generical symlink. See here: https://lintian.debian.org/tags/copyright-refers-to-symlink-license.html > 7. Fixed in /debian directory, should I apply a patch to the rest of the > source tree as well? No. The upstream code must be left intact. > Should I upload what I've got so far? I thought it might be best to wait until > all these points are cleared up. You can upload now. Thanks. Eriberto > On Saturday, September 27, 2014 16:57:18 Eriberto wrote: >> Hi Shawn, >> >> You need do some adjustments in your package. Please: >> >> 1. d/changelog: rewrite this file, refering to the last version only. >> You can see an example here[1]. >> >> [1] https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#changelog >> >> 2. d/control: >> - Your Vcs-* points to a empty repository. >> - The Vcs-Git has an invalid address. >> - In long description, change the last semicolon (in list) by a dot. >> >> 3. d/copyright: >> - You need inspect each file to find the individual authors and >> licenses. You can use -> egrep -sriA25 '(copyright|public domain)' * >> <- to do it. >> - I saw several files licensed as GPL-2+. >> - You can see an example here[2]. >> >> [2] >> http://metadata.ftp-master.debian.org/changelogs/main/e/ext4magic/unstable_ >> copyright >> >> 4. d/lintian-overrides: the correct comment must be about the symlink >> refers to a package dependency. >> >> 5. d/patches/fix_about_dialogue.diff: do you sent this patch to >> upstream? You can fix the upstream years too... >> >> 6. Do you have a Lintian message: kcm-ufw: >> copyright-refers-to-symlink-license usr/share/common-licenses/GFDL. >> >> 7. Please, remove all excessive blank lines from end of files. Use >> 'tail -n1 *' to see these lines. >> >> Cheers, >> >> Eriberto -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/cap+dxjdrgz++z_novvebs9hcax3uxtsqgfjhmwpeg6kmtoo...@mail.gmail.com
