A forgot detail: I would like to suggest you to add a GPG signature for your upstream code in next release. To see more details, '$ man uscan' (search for pgpsigurlmangle). To sign your tarball, you can use 'gpg -ab <tarball_name>'.
Cheers, Eriberto 2014-09-03 11:24 GMT-03:00 Ruben Undheim <ruben.undh...@gmail.com>: > Hi Eriberto, > >> >> >> Sorry, but I need you review each file. As an example, Everaldo Canuto >> hasn't copyright over src/gui/osm-utils.h, src/gui/osm-gps-map-ais.c >> and src/gui/osm-gpsmap-ais.h. There is a other case. I didn't see the >> name Matti Aarnio in copyright. Use 'grep -sriA30 copyright *' to >> search. Thanks! >> > > I made yet another attempt and uploaded. I'm not sure if I understand fully. > Do I also have to split up the * target if not every copyright holder > listed holds the copyright for every single other file? > > >> >> Sorry. I will try to explain better. I saw in your patch: >> >> - tmp_file = >> fopen("/usr/local/share/doc/gnuais/gnuais.conf-example","r"); >> + tmp_file = >> fopen("/usr/local/share/doc/gnuais/examples/gnuais.conf-example","r"); >> >> - ret = >> cpfile(conf_home_folder,"/usr/local/share/doc/gnuais/gnuais.conf-example"); >> + ret = >> cpfile(conf_home_folder,"/usr/local/share/doc/gnuais/examples/gnuais.conf-example"); >> >> Now I know your intention. But, from FHS[1]: >> >> "The /usr/local hierarchy is for use by the system administrator when >> installing software locally. It needs to be safe from being >> overwritten when the system software is updated." >> >> Your package can't touch in /usr/local. Then, the original upstream >> path must be kept because you can't create a /examples/ directory >> inside /usr/local. Therefore, this path will never exist. >> >> [1] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRLOCALLOCALHIERARCHY > > I just did the same change to the /usr/local/share/... path as for > /usr/share/. I agree that > it is unnecessary, but I don't see that it could cause any problems > since the program tries > to open the files with READ permission. > I have updated the patch so that it only changes /usr/share/.. > > > >> >> Ok. There are cases that you need a "text" in menu. You can keep it . >> But I think that it is uncommon. Maybe you can use a script to start >> gnuais and gnuaisgui via menu. What you think about it? >> > > I think it's a good idea. But since I'm the main upstream contributor, > I believe I will attempt to make this a bit more user-friendly in the > next version (that gnuais is automatically started in the background > by gnuaisgui if not already running). > > > Thanks a lot, > > Ruben > > > -- > To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org > Archive: > https://lists.debian.org/CA+ChNyVPX0Ec1e63hyn8n0+S75Cu-CvpanpxGv=z42qxjjq...@mail.gmail.com > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CAP+dXJcbjDhx_=plnjtsf4sghzagpbqp9dmz_r15p3f+hn4...@mail.gmail.com