2014-09-02 16:45 GMT-03:00 Joseph Bisch <joseph.bi...@gmail.com>: > Hi Eriberto, > > Thanks for reviewing my package. I reuploaded it to mentors.d.n. I > also uploaded to a private git repository, because I don't have > access to collab-maint. See my notes below on your points.
You're welcome. > On Tue, Sep 02, 2014 at 10:25:06AM -0300, Eriberto Mota wrote: > >> 3. d/control: >> - Why the package recommends zenity | kdebase-bin? I am afraid >> because kdebase-bin is a monster (a detail: I use KDE). I need you >> invetigate this dependency. >> - Do you have access to collab-maint? If not, you must create an >> external VCS and import all data. >> - The long description appears a mix between long description and >> README. Please, move this content to README.Debian (you can create a >> new section below the Jari Aalto and put a footer with your name): >> >> >> > > I moved all the stuff to README.Debian. Please, remove: 'From d/control:'. > I don't have access to collab-maint, > so I changed the Vcs fields to a private repo. Ok. > I think the package > recommends zenity | kdebase-bin because of Kdialog which can be used as an > alternative to zenity. What do you think I should do about it? I agree. > >> >> d/copyright: you need update the upstream name list and years in >> 'Files: *'. you can use 'grep -sri copyright * | grep -v debian'. > > Done > A Lintian message: W: winetricks source: missing-license-paragraph-in-dep5-copyright lgpl-2.1 >> d/watch: doesn't show the last version. > > What do you suggest I do? The watch file is setup for the actual releases, > but the previous maintainer has been packaging the version directly from > svn. I guess I can figure out a way to get the watch file working with > Google Code source browser. My suggestion. It won't allow downloads but you will know if have a new version (commit): version=3 opts="dversionmangle=s/.*svn//" \ http://code.google.com/p/winetricks/source/list detail\?r=(\d+) Another option is package the version available at http://winetricks.org/download/releases/. Cheers, Eriberto -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CAP+dXJdAt-92=ehzq+dhvc7ypyhqmhr7eiipbwobzjqqz33...@mail.gmail.com
