-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 21.08.2014 21:16, Eriberto Mota wrote:
> tags 758815 moreinfo thanks
>
>
> Hi Dariusz.
>
> Please:
>
> 1. d/changelog: add an explanation about why your removed the -dfsg. Please,
> see the field 'Source' in d/copyright header.
Done, good catch thanks.
>
> 2. d/control: in 'Package: libircclient-dev', remove 'Pre-Depends:
> ${misc:Pre-Depends}'.
Done.
>
> 3. d/copyright: - Fix the 'Source' field in header.
Fixed.
> - See it[1] and put the correct range of the years for each Debian
> maintainer.
Fixed.
> - Update the upstream copyright years (2004-2013).
Fixed.
> - Search with 'grep -sri copyright * | grep -v Georg' for other authors.
Did that. Added Authors from cocoa/ folder.
>
> [1] https://packages.qa.debian.org/libi/libircclient.html
>
> 4. libircclient-dev.install: remove .a. From Maintainers Guide[2]:
>
> Shared libraries are distributed as *.so files. (Neither *.a files nor *.la
> files)
>
> [2] https://www.debian.org/doc/manuals/maint-guide/advanced.en.html[2]
>
I will leave them if it is ok with you.
> 5. Remove useless file README.source.
Done.
>
> 6. Please, tell me why you make a patch. Your package is installing
> libircclient.h only. The original program is installing libirc_options.h,
> libircclient.h, libirc_errors.h, libirc_rfcnumeric.h and libirc_events.h.
Good catch, super thanks. I added installing of other header files. I made patch
because the legacy build system builds only one .so file, and I was advised on
#debian-mentors that it is better to patch build system than to make symlinks
for ldconfig in d/rules.
>
> 7. The upstream site has lot[3] of instructions about the library. I suggest
> you create a README.Debian with notice about it.
>
> [3] http://www.ulduzsoft.com/libircclient
>
I added this, you are right it is nice to have some doc.
I reuploaded to mentors, also this can be found in my collab-maint repo.
- --
Dariusz Dwornikowski,
Institute of Computing Science, Poznań University of Technology
www.cs.put.poznan.pl/ddwornikowski/
room 2.7.2 BTiCW | tel. +48 61 665 29 41
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJT9xlYAAoJECEac8aaew/HcTsP/1VgYlvF9tStexwMEKogLRm/
3HUHFiStFwJ094m2GbECfEKaIMclHcVqSbQVLGpOqESOgDmhsIEXS3E8pNe3qOxr
nb3pzTIhNOLo97CCR6zoMKQRMjPNp1BiQweQYuFw+UtwZobdBz5y2KEwBugCYSmg
K3wFthwL5P2shc9yUvvpJJJyrJfe6YixhlwGiBh+gP1h5XdkjmtSH/UOfPP7ib0G
J+cjTLmKu8ydeedKaItPOE4waCF8a6HzAWeWvH62u/wSTqg7J50rTSqYB6CSe4P2
EqG8UL9eJnbGwBP7I5ZoorctqCuoCsYoeoWELRoU+yqIPvOgHpt7OLwPV55Lxj68
LdGTyynjb5kzUf/pT9ErVxE4eFlPOoB9VZ0KiSSvwv2/gTWTKVq+C0RboreJ2Qz7
LjOsaxipe2bz/2iGT+MngleS6Ljt/Cn2f1q6G8ATMYnZi4pzldlqT5mJbMNyTrAu
/sZSGYd4GF2tKkHsZYKdMeCg0w/ogrEfQwlAKZECk6hsiWrxBMhGkYnb8Ngm1yXs
Q1f3Fa6o4+dGuzkzwACZUB7msew2pv4bNaceKBcFrQmkkKcM3OUbmtMCy9/kw6QC
b875AH6fY+5xoWrfplrTWMlk8bk8MrXEqg0+Njh2IQxwEUMmBIR3yjwsu0v9LVOS
OnsHK4Jk964V8XxkQKVF
=ZgKY
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53f71958.6080...@cs.put.poznan.pl
