2014-08-19 6:53 GMT-03:00 Arturo Borrero Gonzalez
<arturo.borrero.g...@gmail.com>:

>> 4. d/copyright: the upstream copyright years must be 2010-2012 and the
>> license is clearly GPL-3+.
>>
>
> Done.

You forgot to put 2010-2012

>> 6. d/rules: I suggest you use a file d/install instead the
>> override_dh_install. But you can keep it.
>
> Keeping it. Using the override eases renaming the file.

I agree with you. I didn't see this detail. Sorry.

>> 7. d/watch: not working. Is it a preparation to future?
>>
>
> Yes. Upstream doesn't do any release by tarball or git tags ATM.


Good! Another detail: please, remove the useless first line.

>
> Thanks for your time and review. Regards.

Thanks for your work. Waiting for you to upload the package.

Cheers,

Eriberto


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CAP+dXJdQCckAQg-pyDGjL7V+3wn7bqUODdSgTwo8v+T3agN=u...@mail.gmail.com

Reply via email to