On Wed, Jul 23, 2014 at 11:26 PM, Vincent Bernat <ber...@debian.org> wrote:
> ❦ 23 juillet 2014 15:41 -0700, Andrew Kelley <superjo...@gmail.com> : > > > Package: sponsorship-requests > > Severity: wishlist > > > > Dear mentors, > > > > I am looking for a sponsor for my package "liblaxjson": > > > > * Package name : liblaxjson > > Version : 1.0.2-1 > > Upstream Author : Andrew Kelley <superjo...@gmail.com> > > * URL : https://github.com/andrewrk/liblaxjson > > * License : Expat > > Section : libs > > Hi Andrew! > Thank you for taking the time to review this package, I very much appreciate it. > > In debian/control, use "debhelper >= 9". 9.0.0 never was a debhelper > version. > Done. > > In debian/control, Vcs-Git is obviously incorrect (mismatch with > Vcs-Browser). > Fixed. > > Please, make liblaxjson1 multiarch-enabled. See: > https://wiki.debian.org/Multiarch Done. I used a GNUInstallDirs patch and did not submit it upstream because of https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739876 > On top of debian/rules, remove comments saying this is a sample > file. This is not anymore. You can remove the whole notice. > Done. > In debian/rules, you point to check if dh_installchangelogs would handle > CHANGELOG.md automatically. Please, check. From the source code of > dh_installchangelogs, it should find CHANGELOG.md without any help. Oops. I actually did check and discovered that the override was necessary. I have now removed the comment. Thanks again. If you want to have another look, I have uploaded 1.0.2-2: http://mentors.debian.net/debian/pool/main/libl/liblaxjson/liblaxjson_1.0.2-2.dsc
