On 18/07/14 15:38, Vincent Legout wrote: > Hi Tomasz, Hi Vincent, how sponsors are able to spot all these things, amazes me. :)
> > Tomasz Buchert <tomasz.buch...@inria.fr> writes: > > > I am looking for a sponsor for my package "tiptop": > > I'm interested in sponsoring tiptop, I just have some comments: > > The package doesn't provide the tiptoprc file from upstream. I think it > would make sense to install it somewhere even if it is not used, maybe > in /usr/share/doc/tiptop. Done. > > It seems the git repository and the dsc on mentors differ. I think the > git version is correct, you only need to close #754932. The descriptions > are also different. Yeah, it was kind of mess, but it should be fine now (I retitled bugs as well). > > According to the source files in src/, the copyright is 2011-2014 > Inria. Thus I believe you should also add Inria in debian/copyright. Done. > > In debian/copyright, tiptop is GPL-2 but you used the text for GPL-2+ > (i.e. with or (at your option) any later version). You also have 2 > identical paragraphs for the debian/ directory. I think it is fixed now. However, if you could verify license boilerplate for GPL-2, I would appreciate it. > > I can't build the package twice in a row. Not sure why, but maybe > because these files are not deleted by dh clean: Makefile, config.h, > config.log, config.status and src/Makefile. I didn't investigate too > much but it also seems that running debclean twice in a row fails > because ./configure is removed by dh_autoreconf_clean and is needed in > Makefile. I delete these spurious files in dh_clean now. It is a bit hackish, though, but I've contacted upstream about this issue. Consider it to be a temporary workaround. > > I think there is a typo in the manpage: s/if forked/is forked/ Patch queue updated and upstream informed. > > Could you please fix this and I'll be happy to upload tiptop. The work is here: http://anonscm.debian.org/cgit/collab-maint/tiptop.git/ (starting with b2ee0ea83) The new upload here: http://mentors.debian.net/package/tiptop > > Thanks, > Vincent Cheers, Tomasz -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140723095737.ga...@buchert.pl
