On Sun, May 18, 2014 at 10:52 AM, Cédric Barboiron <c...@winkie.fr> wrote: > On Sat, 17 May 2014 16:02:29 -0700 > Vincent Cheng <vch...@debian.org> wrote: > >> > >> > * debian/patches/03fix_freebsd_build: >> > - use $CC in SHLIB_LD (instead of hardcoded ld) >> >> Why are you patching automatically generated files (configure, in this >> case)? I'm certainly not an autotools expert, but can't you patch >> aclocal.m4 instead and then run autoreconf (or rather, use >> dh-autoreconf) afterwards? >> > > Hi Vincent, > > Thanks for your feedback. You're right, and indeed my first local patch > was against aclocal.m4. > > But it did introduce automake + autoconf as build dependencies (we > were using upstream configure before), and was getting more complicated > than a one-line fix to build on kfreebsd. I agree that it is not a good > excuse.
I would argue that introducing more build dependencies (especially common ones like autoconf/automake) is a lesser evil than patching auto-generated files. :) > Well, since I've read /usr/share/doc/autotools-dev/README.Debian.gz and > tried to use dh-autoreconf properly. You can find the updated package > at the same place : > http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc - Why does debian/control now have "Build-Conflicts: autoconf2.13, automake1.4"? - debian/source/options should be unnecessary (dh-autoreconf takes care of removing/restoring autotools cruft before/after build) Regards, Vincent -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/caczd_tdtrdw-cao-jgurchhp4fs1nu1qtulovy95sd5ssf0...@mail.gmail.com
