On Wed, Jan 22, 2014 at 10:22:12AM +0100, Johannes Schauer wrote: > Hi Ahmed, > > Quoting أحمد المحمودي (2014-01-22 08:51:02) > > Sorry, that I forgot to attach it. Please find it attached in this email. > > thanks! What problem does that patch fix? > > The only differences in comparison to my patch that I can make out are: > > 1) you add -lpthread but `pkg-config --libs fuse` already takes care of > adding > that
Ok, you can drop that change. > 2) you explicitly write `$(CC) $^ $(CFLAGS) $(LDFLAGS) -o $@` but this > already > is the implicit default make rule to compile C files, so there is no need > to explicitly state it, is there? Actually what happens implicitly (at least on Ubuntu precise) is: $(CC) $(CFLAGS) $(LDFLAGS) $^ -o $@ which causes the compilation to fail, because the -l<...> should be after the object files (or source files in this case). -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0xEDDDA1B7 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7
signature.asc
Description: Digital signature
