On Tue, May 14, 2013 at 7:44 AM, Neil Wallace <rowinggol...@gmail.com> wrote:
> Dear mentors,
>
> I am looking for a sponsor for my package "regexxer"
Hi Neil,
I'm willing to sponsor this package. A few comments first.
Lintian isn't happy with your changelog:
W: regexxer: debian-changelog-has-wrong-weekday 2013-08-26 is a Monday
N:
N: The date in the changelog entry is not consistent with the actual
N: weekday. Either the date is wrong or the weekday is wrong.
N:
N: To avoid problems like this, consider using a tool like dch(1) or
N: date(1) to generate the date. Example:
N:
N: $ date -R -ud '2013-11-05 23:59:59'
N: Tue, 05 Nov 2013 23:59:59 +0000
N:
N: Severity: normal, Certainty: certain
N:
N: Check: changelog-file, Type: binary
N:
Also, you should close the ITA bug in the changelog using the format:
(Closes: #569345)
Since we're fixing the changelog anyway, it's a bit confusing that you say you:
Remove debian/patches/glib-single-include.patch
but then:
debian/patches/glib-single-include.patch:
Updated to fix one more include.
and of course that patch is present in the package.
If you clean these little things up, I'll upload the package. Lintian
points out a few other things that would be nice, but since the
package is already in Debian I don't consider them blockers. You
should look into fixing them in a future upload though:
W: regexxer: hardening-no-relro usr/bin/regexxer
N:
N: This package provides an ELF binary that lacks the "read-only
N: relocation" link flag. This package was likely not built with the
N: default Debian compiler flags defined by dpkg-buildflags. If built using
N: dpkg-buildflags directly, be sure to import LDFLAGS.
N:
N: Refer to http://wiki.debian.org/Hardening for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: binaries, Type: binary, udeb
N:
I: regexxer: hardening-no-fortify-functions usr/bin/regexxer
N:
N: This package provides an ELF binary that lacks the use of fortified libc
N: functions. Either there are no potentially unfortified functions called
N: by any routines, all unfortified calls have already been fully validated
N: at compile-time, or the package was not built with the default Debian
N: compiler flags defined by dpkg-buildflags. If built using
N: dpkg-buildflags directly, be sure to import CPPFLAGS.
N:
N: NB: Due to false-positives, Lintian ignores some unprotected functions
N: (e.g. memcpy).
N:
N: Refer to http://wiki.debian.org/Hardening and
N: http://bugs.debian.org/673112 for details.
N:
N: Severity: normal, Certainty: wild-guess
N:
N: Check: binaries, Type: binary, udeb
N:
Thanks!
-- Andrew Starr-Bochicchio
Ubuntu Developer <https://launchpad.net/~andrewsomething>
Debian Developer <http://qa.debian.org/developer.php?login=asb>
PGP/GPG Key ID: D53FDCB1
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/cal6k_awedeyxhn-seadblxahz9muufehfozww8lp1uywxvv...@mail.gmail.com
