On Tue, Sep 3, 2013 at 5:45 AM, Beren Minor <beren.minor+deb...@gmail.com> wrote: > BTW, I also have a GemRB package that requires sponsorship. I've > recently joined the Debian Games Team to maintain it, but I have > little time to chase sponsors. So, if you have some time to spend and > want to have a look at it, it would be awesome. The sources of the > package are in the pkg-games source repo [2]. > [2] http://anonscm.debian.org/gitweb/?p=pkg-games/gemrb.git;a=summary
Thanks for your work, here are some comments: 1) Changelog is confusing, there are multiple entries claiming upload to unstable that has never been uploaded. The ITP bug is closed very low on the list. Also, this is labeled as 0.8.0-3, but this is the first upload to Debian. For the sake of clarity in the Debian archive, I think you should reduce the debian/changelog to a single entry: 0.8.0-1, "First packaging for Debian (Closes: #658887)". (or close which ever of the ITP bugs you want to close) 2) It appears that several of the packages depends on non-free data, but it also appears that the engine can run free content. Is the package usable without any content, or does it depend on non-free content? (i.e., if a user downloads the package, will they be able to do something with it "out of the box")? I'm trying to see if this should be in "main" or "contrib." Looking at the upstream website, it appears that the package should be "contrib." 3) Lintian report: I: gemrb: desktop-entry-lacks-keywords-entry usr/share/applications/gemrb.desktop I: libgemrb: hardening-no-fortify-functions usr/lib/gemrb/plugins/2DAImporter.so I: libgemrb: hardening-no-fortify-functions usr/lib/gemrb/plugins/BAMImporter.so I: libgemrb: hardening-no-fortify-functions usr/lib/gemrb/plugins/CREImporter.so W: libgemrb: postinst-has-useless-call-to-ldconfig W: libgemrb: postrm-has-useless-call-to-ldconfig the first 4 are minor and can be fixed if you'd like to whenever you get a chance. The last two should be overridden for being a bug in debhelper. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=205142 4) the debian/control VCS-Git and VCS don't match the one you gave me (http://anonscm.debian.org/gitweb/?p=pkg-games/gemrb.git;a=summary) 5) I was a little uneasy about the vvc files, they are binary blobs so I was worried about where they came from (copyright and license), but I found: http://gemrb.org/iesdp/file_formats/ie_formats/vvc_v1.htm I think it is ok, they seem to be from gemrb and not taken from closed-source game content. You don't need to do anything about them. Cheers, Scott -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cang8-dbxdolra1kzct_xqleap75mpptnstajphzf6wed-ob...@mail.gmail.com
