Hi, jwilk > I'm a bit late, as the package is already in NEW, but anyway > here's my quick review:
Thank you for your review. I uploaded fixed package to mentors. Could you review it again, and if no problem, then sponsor it? https://mentors.debian.net/package/marisa dget -x http://mentors.debian.net/debian/pool/main/m/marisa/marisa_0.2.4-2.dsc > Why is your .orig.tar different than the one downloaded by uscan? > My fault. I have used --createorig in first dh_make. > Package synopses are not sentences, therefore they shouldn't end with full > stops. Removed full stops. > The Perl package name is wrong; as per Perl Policy S:4.2 it should be > libmarisa-perl. Renamed. > /lib/perl5/i486-linux-gnu-thread-multi-64int/ is certainly not the > correct directory to install Perl modules into... Modified install path in debian/rules to "/usr/lib/perl5/". > According to both Lintian and blhc, at least some parts of the packages > are not built with hardening. Set CFLAGS and LDFLAGS in debian/rules. And use verbose option for extconf.rb. Added manpages. > lintian4python emits: > i: marisa source: python-provides-considered-harmful python-marisa > i: marisa source: python-provides-considered-harmful python3-marisa > w: python-marisa: egg-info-version-mismatch 0.0.0 0.2.4 > e: python-marisa: python-module-in-multi-arch-foreign-package > w: python3-marisa: egg-info-version-mismatch 0.0.0 0.2.4 > e: python3-marisa: python-module-in-multi-arch-foreign-package Set version in setup.py via quilt patch. Removed Multi-Arch field from python package. Best regards, -- Mitsuya Shibata mty.shib...@gmail.com -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CANAWXfiWFcSN1QRJXXjD437a9pgL_95RoMagQ3NaRz7fh=e...@mail.gmail.com
