Hi,
intrigeri wrote (04 Jul 2013 06:49:08 GMT) :
> I plan to review, and hopefully upload bilibop next week.
Here we go.
First, was the target distribution change in debian/changelog
intentional? (0.4.12 has experimental, 0.4.13 has unstable.)
Second, it looks like important changes and refactoring are flowing in
rather quickly, so I'd like to check that you are confident with the
current state of bilibop, and believe it is stable enough to be part
of a Debian release. Do you confirm this?
Also, please keep in mind that once bilibop is uploaded to Debian, the
responsibility of backward compatibility will be yours, as the
maintainer. This being said, while I certainly wouldn't mind a bit
more abstraction / factorization at some places, the code looks solid
enough :)
Some nitpicking follows, that should be fixed before the initial
upload IMHO:
> + myshell="$(awk -F: "\$1 ~ /$(whoami)/ {print \$NF}" /etc/passwd)"
Maybe use `getent' instead?
Also Lintian says:
I: bilibop-common: spelling-error-in-manpage
usr/share/man/man1/drivemap.1.gz informations information
... and a few others, so you probably want to run it in verbose /
pedantic mode and take the results into account.
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/854nbqh0g2....@boum.org
