On Tue, Feb 12, 2013 at 08:30:11PM +0700, Prach Pongpanich wrote: > I am looking for a sponsor for my package "furiusisomount"
Thanks for your work on an existing package. IANADD, so all you get from me is a review. > http://mentors.debian.net/debian/pool/main/f/furiusisomount/furiusisomount_0.11.3.1~repack0-2.dsc I saw that you removed the Vcs-* headers from debian/control. Having the package in version control is a good thing and the infrastructure is already there and set up, maybe you could use it? Otherwise you should probably mention such a change in debian/changelog. There is a patch, that adds a setup.py to ease installation. This patch appears to be useful for others as well, so maybe it can be moved upstream? The patch already contains dep3 style headers to indicate the author, but does not tell whether it was forwarded upstream. Could you ask upstream to apply this patch? Also the version in setup.py appears to be outdated. For completeness I believe that debian/copyright should be mentioning the authors of the translations. You can find a hint that they were not written by Dean Harris in aboutbox.py. In the locale directory there are only mo files, but there is no source. The package is undistributable. This also applies to the one in wheezy, so I have filed a bug #703553. Please prepare both an upload to unstable just fixing this bug and nothing else and an updated upload to experimental with all the other changes as well. brasero is listed in Suggests, but nautilus is listed in Depends. Is nautilus absolutely required for using furiusisomount? If not, could it be demoted to Recommends and that way still be installed by default? Could you spare another look at the package description? Some bullet points have weired casing (uppercase in the middle). The word "automatically" appears to be a bit overused as well. Could you also add some debtags? You can edit tags at http://debtags.debian.net/edit/furiusisomount. Maybe you could try to fix https://bugs.launchpad.net/ubuntu/+source/furiusisomount/+bug/1059504? The immediate issue here is that log_object is not defined in log.py. This is most likely due to some exception from the open call. Just moving the open outside the try block should be fixing the immediate issue. Then very likely an IOError will propagate down. My guess is that the settings_directory is not created, so maybe log.write should ensure that it exists? Helmut -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130320203447.ga19...@alf.mars
