Here is a review: You seem to have sent this RFS bug to debian-mentors instead of submit@bugs.d.o, please read this:
http://wiki.debian.org/Mentors/BTS I would suggest that a non-native package would be more appropriate here, please change debian/source/format to 3.0 (quilt) and change the version number to 1.1.2c-1 The upstream build system should probably install the manual pages, please ask upstream about that. The comments in debian/rules are not needed. No need for both --with autotools_dev and --with autoreconf in debian/rules, please drop autotools_dev. The Homepage link is broken. Standards-Version is out of date, please check the upgrading list and update anything needed. http://www.debian.org/doc/debian-policy/upgrading-checklist I would suggest running wrap-and-sort -sa. The source package is missing a watch file. There are some RFCs in doc/ and RFCs tend to be non-free, please remove them from the source package. Even if they were free, they should be packaged separately if at all. doc/KeyRollover.ps is a generated file, please ensure that it is recreated at build time. The debian/copyright file doesn't properly document all of the copyright holders. soaserial.c contains an unsafe use of system() inside the #ifdef SOA_TEST, the popen calls don't look nice either. Automatic checks: http://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package gcc: tcap.c:266:12: warning: 'tc_printattr' defined but not used [-Wunused-function] tcap.c:282:12: warning: 'tc_color' defined but not used [-Wunused-function] tcap.c:254:12: warning: 'put' defined but not used [-Wunused-function] lintian: W: zkt source: package-needs-versioned-debhelper-build-depends 9 W: zkt source: missing-license-paragraph-in-dep5-copyright bsd-3-clause (paragraph at line 6) W: zkt source: out-of-date-standards-version 3.9.3 (current is 3.9.4) W: zkt: latest-debian-changelog-entry-without-new-date I: zkt: extended-description-is-probably-too-short cme: Configuration item 'Files:"*" License short_name' has a wrong value: license BSD-3-clause is not declared in main License section. Expected blhc: CFLAGS missing (-fPIE) LDFLAGS missing (-fPIE -pie -Wl,-z,now) cppcheck: [dki.c:73]: (error) Memory leak: dkp [zkt-soaserial.c:123]: (error) Width 255 given in format string (no. 1) is larger than destination buffer 'master[255]', use %254s to prevent overflowing it. [zkt-soaserial.c:125]: (error) Width 255 given in format string (no. 1) is larger than destination buffer 'master[255]', use %254s to prevent overflowing it. [zkt-soaserial.c:130]: (error) Resource leak: fp bfbtester: zkt-conf crashes a lot under bfbtester, please look at this. checkbashisms: script ./distribute.sh does not appear to have a #! interpreter line; you may get strange results script ./examples/flat/dist.sh does not appear to have a #! interpreter line; you may get strange results script ./examples/views/viewtest.sh does not appear to have a #! interpreter line; you may get strange results fdupes: ./examples/views/intern/example.net/keyset-example.net. ./examples/views/intern/keyset-example.net. ./examples/views/extern/keyset-example.net. ./examples/views/extern/example.net/keyset-example.net. ./examples/hierarchical/de/example.de/sub.example.de/parent-sub.example.de. ./examples/hierarchical/de/example.de/keyset-sub.example.de. ./examples/hierarchical/de/keyset-example.de. ./examples/hierarchical/de/example.de/keyset-example.de. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caktje6hubgrinlfsssb8qsat3rbyluov9xcsrwvxo8fn5_p...@mail.gmail.com
