Hi Arno, On Sun, Mar 10, 2013 at 7:27 AM, Arno Töll <a...@debian.org> wrote: > Hi Prach, > > as promised here is a review for libapache2-mod-geoip. > > > * Please consider upgrading to new style (dh >= 7) rules style. It makes > life easier to you and is more forward oriented. That said, your rules > file looks ok but you could ease life to all of us, including you. > * While you're at it, remove the boilerplate copyright messages in > debian/rules. They are not needed.
Done > * Please consider using the copyright format formerly known as dep5 for > debian/copyright: > http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Updated. > * Since you build a single binary package only I agree with your suggestion, done > * Your watch file does not work: Upstream file download and the download link doesn't contain the version number. (explain in debian/watch) > * There is no policy version 3.9.3.4. Done, I forget it. > * Please consider using a VCS for your packaging This repo is already in GitHub, I can''t access Alioth collab-maint. > By the way: If you want, we can do another upload to experimental for > Apache 2.2 with you as a maintainer set. OK, Thank you very much. Last updated : dget -x http://mentors.debian.net/debian/pool/main/liba/libapache2-mod-geoip/libapache2-mod-geoip_1.2.8-1.dsc Changes since the last upload: libapache2-mod-geoip (1.2.8-1) experimental; urgency=low * New maintainer. (Closes: #670999) * New upstream release. (Closes: #666795) - Support Apache 2.4 * Adapt "sourceful transition towards Apache 2.4" patch from Arno Töll - Replace apache2-threaded-dev with apache2-dev in Build-Depends - Drop apache2.2-common in Depends - Drop libapache2-mod-geoip.{install,postinst,postrm} - Add debian/apache2 file * Update copyright file to version 1.0 format * Bump debhelper compat to level 9 - Convert debian/rules to debhelper-7 style - Use dh $@ --with apache2 in d/rules - Remove package prefix libapache2-mod-geoip.{docs,dirs,examples}, it is useless when build a single binary package * Add get-orig-source in debian/rules and README.source * Update debian/watch and explain why doesn't work * Add Vcs-* fields in debian/control * Bump to Standards-Version 3.9.4, no changes needed -- Prach Pongpanich -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAF=n8MLE8qsy+2axUb78jXOnDMwe6oRvHpW=gzzhrdcp0cc...@mail.gmail.com
