Hi Paul, >On Mon, Mar 4, 2013 at 6:19 PM, Paul Wise <p...@debian.org> wrote: > I don't intend to sponsor this package, but here is a review: > > You might want to get involved in the ocaml team: > > http://wiki.debian.org/Teams/OCamlTaskForce
I already done. > Please drop the unnessecary information from the patch header, > including the partial changelog and the stuff about patch tagging > guidelines. > > Please get the patch included upstream. > > Please improve your watch file: > Fixed > > There should be no need for .PHONY in debian/rules. > Fixed > The lintian override should probably be replaced by a bug against > lintian or blhc. I see in debian-ocaml-maint [1] but I can't find a bug against lintian. [2] > > The copyright/license info for rss_date.mli/rss_date.ml is incomplete. Fixed, dual license > lintian: > > P: librss-ocaml: no-upstream-changelog > P: librss-ocaml-dev: no-upstream-changelog lintian overrides, upstream changelog is not available (#513544). > ocamlc: > > File "rss_date.ml", line 220, characters 10-280: > Warning 25: bad style, all clauses in this pattern-matching are guarded. > similarity-tester: > > rss_types.ml consists for 85 % of ./rss.ml > material I will discuss with the upstream author. dget -x http://mentors.debian.net/debian/pool/main/o/ocamlrss/ocamlrss_2.0-1.dsc [1] https://lists.debian.org/debian-ocaml-maint/2012/05/msg00091.html [2] http://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=lintian Regrads -- ปรัชญ์ พงษ์พานิช Prach Pongpanich http://prach-public.blogspot.com -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAF=n8mloomucm-pr58kdq6wz3wc788v8vf-b9v77kgsaklb...@mail.gmail.com
