Il 01/02/2013 21:09, Jakub Wilk ha scritto: > * Giulio Paci <giuliop...@gmail.com>, 2013-02-01, 00:03: >>> Speaking of which, I had a look at the list of exported symbols, and it's >>> kinda messy... Some symbols have very generic names. Upstream should >>> consider putting them into >>> a namespace. >> I think I can work on this and have it included upstream. > > Great.
Done in patch 1009_add_mitlm_namespace.patch. >>>> 1007_escape_filename.patch >>>> The latter fixes .bz2 handling and should work on Windows as well >>>> (although I have not tested it yet on a real Windows system). >>> I would be surprised if decompression worked correctly, though I don't have >>> access to a Windows system to test it. >>> >>> "^" is a cmd.exe escape character, but then the executed program does >>> argument parsing on its own. It's usually done by the MSVC++ runtime: >>> http://msdn.microsoft.com/en-us/library/ms880421.aspx >> >> You are right, in fact I first implemented the command line parsing escape. >> Then I realized that I also needed cmd.exe escape. Then I guessed that I >> only needed cmd.exe >> escape as ">" and "<" are breaking the command line. > > That is correct for compression, but (unless I'm missing something) there is > no "<" or ">" in the _decompression_ commandlines. You are right. It is fixed now. I also introduced patches 1010_fix_segmentation_fault_on_interpolate_ngram.patch and 1011_replace_hashmap_with_unordered_map.patch. Bests, Giulio. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/511aebde.40...@gmail.com
